* [PATCH] team: unsyc the devices addresses when port is removed
@ 2013-03-07 17:59 Vlad Yasevich
2013-03-07 18:30 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Vlad Yasevich @ 2013-03-07 17:59 UTC (permalink / raw)
To: netdev; +Cc: Vlad Yasevich, Jiri Pirko
When a team port is removed, unsync all devices addresses that may have
been synched to the port devices.
CC: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
drivers/net/team/team.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 05c5efe..bf34192 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1138,6 +1138,8 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
netdev_upper_dev_unlink(port_dev, dev);
team_port_disable_netpoll(port);
vlan_vids_del_by_dev(port_dev, dev);
+ dev_uc_unsync(port_dev, dev);
+ dev_mc_unsync(port_dev, dev);
dev_close(port_dev);
team_port_leave(team, port);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] team: unsyc the devices addresses when port is removed
2013-03-07 17:59 [PATCH] team: unsyc the devices addresses when port is removed Vlad Yasevich
@ 2013-03-07 18:30 ` Jiri Pirko
2013-03-07 21:36 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2013-03-07 18:30 UTC (permalink / raw)
To: Vlad Yasevich; +Cc: netdev
Thu, Mar 07, 2013 at 06:59:25PM CET, vyasevic@redhat.com wrote:
>When a team port is removed, unsync all devices addresses that may have
>been synched to the port devices.
This is looking good to me. Thanks for spotting this bug.
Acked-by: Jiri Pirko <jiri@resnulli.us>
>
>CC: Jiri Pirko <jiri@resnulli.us>
>Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
>---
> drivers/net/team/team.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index 05c5efe..bf34192 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -1138,6 +1138,8 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
> netdev_upper_dev_unlink(port_dev, dev);
> team_port_disable_netpoll(port);
> vlan_vids_del_by_dev(port_dev, dev);
>+ dev_uc_unsync(port_dev, dev);
>+ dev_mc_unsync(port_dev, dev);
> dev_close(port_dev);
> team_port_leave(team, port);
>
>--
>1.7.7.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] team: unsyc the devices addresses when port is removed
2013-03-07 18:30 ` Jiri Pirko
@ 2013-03-07 21:36 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-07 21:36 UTC (permalink / raw)
To: jiri; +Cc: vyasevic, netdev
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 7 Mar 2013 19:30:00 +0100
> Thu, Mar 07, 2013 at 06:59:25PM CET, vyasevic@redhat.com wrote:
>>When a team port is removed, unsync all devices addresses that may have
>>been synched to the port devices.
>
>
> This is looking good to me. Thanks for spotting this bug.
>
> Acked-by: Jiri Pirko <jiri@resnulli.us>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-07 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07 17:59 [PATCH] team: unsyc the devices addresses when port is removed Vlad Yasevich
2013-03-07 18:30 ` Jiri Pirko
2013-03-07 21:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).