From: Stephen Hemminger <stephen@networkplumber.org>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jesse@nicira.com
Subject: Re: [PATCH net-next 1/4] net: Add skb_headers_offset_update helper function.
Date: Thu, 7 Mar 2013 21:40:25 -0800 [thread overview]
Message-ID: <20130307214025.639c713c@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1362698500-2411-1-git-send-email-pshelar@nicira.com>
On Thu, 7 Mar 2013 15:21:40 -0800
Pravin B Shelar <pshelar@nicira.com> wrote:
> +static void skb_headers_offset_update(struct sk_buff *skb, int off)
> +{
> + /* {transport,network,mac}_header and tail are relative to skb->head */
> + skb->transport_header += off;
> + skb->network_header += off;
> + if (skb_mac_header_was_set(skb))
> + skb->mac_header += off;
> + skb->inner_transport_header += off;
> + skb->inner_network_header += off;
> +}
> +
Won't this cause an unused function warning if NET_SKBUFF_DATA_USES_OFFSET is defined?
next prev parent reply other threads:[~2013-03-08 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 23:21 [PATCH net-next 1/4] net: Add skb_headers_offset_update helper function Pravin B Shelar
2013-03-08 5:40 ` Stephen Hemminger [this message]
2013-03-08 7:23 ` Pravin Shelar
-- strict thread matches above, loose matches on Subject: below --
2013-02-16 1:06 Pravin B Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307214025.639c713c@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox