* [PATCH] bridging: fix rx_handlers return code
@ 2013-03-08 17:03 Cristian Bercaru
2013-03-08 17:14 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Cristian Bercaru @ 2013-03-08 17:03 UTC (permalink / raw)
To: davem; +Cc: Cristian Bercaru, eric.dumazet, netdev
The frames for which rx_handlers return RX_HANDLER_CONSUMED are no longer
counted as dropped. They are counted as successfully received by
'netif_receive_skb'.
This allows network interface drivers to correctly update their RX-OK and
RX-DRP counters based on the result of 'netif_receive_skb'.
Signed-off-by: Cristian Bercaru <B43982@freescale.com>
---
net/core/dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 9610389..609ac45 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3444,6 +3444,7 @@ ncls:
}
switch (rx_handler(&skb)) {
case RX_HANDLER_CONSUMED:
+ ret = NET_RX_SUCCESS;
goto unlock;
case RX_HANDLER_ANOTHER:
goto another_round;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bridging: fix rx_handlers return code
2013-03-08 17:03 [PATCH] bridging: fix rx_handlers return code Cristian Bercaru
@ 2013-03-08 17:14 ` Eric Dumazet
2013-03-08 17:20 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2013-03-08 17:14 UTC (permalink / raw)
To: Cristian Bercaru; +Cc: davem, netdev
On Fri, 2013-03-08 at 19:03 +0200, Cristian Bercaru wrote:
> The frames for which rx_handlers return RX_HANDLER_CONSUMED are no longer
> counted as dropped. They are counted as successfully received by
> 'netif_receive_skb'.
>
> This allows network interface drivers to correctly update their RX-OK and
> RX-DRP counters based on the result of 'netif_receive_skb'.
>
> Signed-off-by: Cristian Bercaru <B43982@freescale.com>
> ---
Signed-off-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bridging: fix rx_handlers return code
2013-03-08 17:14 ` Eric Dumazet
@ 2013-03-08 17:20 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-08 17:20 UTC (permalink / raw)
To: eric.dumazet; +Cc: B43982, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 08 Mar 2013 09:14:10 -0800
> On Fri, 2013-03-08 at 19:03 +0200, Cristian Bercaru wrote:
>> The frames for which rx_handlers return RX_HANDLER_CONSUMED are no longer
>> counted as dropped. They are counted as successfully received by
>> 'netif_receive_skb'.
>>
>> This allows network interface drivers to correctly update their RX-OK and
>> RX-DRP counters based on the result of 'netif_receive_skb'.
>>
>> Signed-off-by: Cristian Bercaru <B43982@freescale.com>
>> ---
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-08 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-08 17:03 [PATCH] bridging: fix rx_handlers return code Cristian Bercaru
2013-03-08 17:14 ` Eric Dumazet
2013-03-08 17:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).