netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v4 3/4] ipv6: stop multicast forwarding to process interface scoped addresses
@ 2013-03-08 12:07 Hannes Frederic Sowa
  2013-03-08 16:30 ` YOSHIFUJI Hideaki
  0 siblings, 1 reply; 3+ messages in thread
From: Hannes Frederic Sowa @ 2013-03-08 12:07 UTC (permalink / raw)
  To: netdev; +Cc: yoshfuji

v2:
a) used struct ipv6_addr_props

v3:
a) reverted changes for ipv6_addr_props

v4:
a) do not use __ipv6_addr_needs_scope_id

Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
 net/ipv6/ip6_input.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
index b1876e5..e33fe0a 100644
--- a/net/ipv6/ip6_input.c
+++ b/net/ipv6/ip6_input.c
@@ -281,7 +281,8 @@ int ip6_mc_input(struct sk_buff *skb)
 	 *      IPv6 multicast router mode is now supported ;)
 	 */
 	if (dev_net(skb->dev)->ipv6.devconf_all->mc_forwarding &&
-	    !(ipv6_addr_type(&hdr->daddr) & IPV6_ADDR_LINKLOCAL) &&
+	    !(ipv6_addr_type(&hdr->daddr) &
+	      (IPV6_ADDR_LOOPBACK|IPV6_ADDR_LINKLOCAL)) &&
 	    likely(!(IP6CB(skb)->flags & IP6SKB_FORWARDED))) {
 		/*
 		 * Okay, we try to forward - split and duplicate
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v4 3/4] ipv6: stop multicast forwarding to process interface scoped addresses
  2013-03-08 12:07 [PATCH net-next v4 3/4] ipv6: stop multicast forwarding to process interface scoped addresses Hannes Frederic Sowa
@ 2013-03-08 16:30 ` YOSHIFUJI Hideaki
  2013-03-08 17:28   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki @ 2013-03-08 16:30 UTC (permalink / raw)
  To: netdev, David Miller, YOSHIFUJI Hideaki

Hannes Frederic Sowa wrote:
> v2:
> a) used struct ipv6_addr_props
> 
> v3:
> a) reverted changes for ipv6_addr_props
> 
> v4:
> a) do not use __ipv6_addr_needs_scope_id
> 
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
>  net/ipv6/ip6_input.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
> index b1876e5..e33fe0a 100644
> --- a/net/ipv6/ip6_input.c
> +++ b/net/ipv6/ip6_input.c
> @@ -281,7 +281,8 @@ int ip6_mc_input(struct sk_buff *skb)
>  	 *      IPv6 multicast router mode is now supported ;)
>  	 */
>  	if (dev_net(skb->dev)->ipv6.devconf_all->mc_forwarding &&
> -	    !(ipv6_addr_type(&hdr->daddr) & IPV6_ADDR_LINKLOCAL) &&
> +	    !(ipv6_addr_type(&hdr->daddr) &
> +	      (IPV6_ADDR_LOOPBACK|IPV6_ADDR_LINKLOCAL)) &&
>  	    likely(!(IP6CB(skb)->flags & IP6SKB_FORWARDED))) {
>  		/*
>  		 * Okay, we try to forward - split and duplicate
> 
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

And I think this should go to -stable as well,.

--yoshfuji

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v4 3/4] ipv6: stop multicast forwarding to process interface scoped addresses
  2013-03-08 16:30 ` YOSHIFUJI Hideaki
@ 2013-03-08 17:28   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-08 17:28 UTC (permalink / raw)
  To: yoshfuji; +Cc: netdev

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Sat, 09 Mar 2013 01:30:20 +0900

> Hannes Frederic Sowa wrote:
>> v2:
>> a) used struct ipv6_addr_props
>> 
>> v3:
>> a) reverted changes for ipv6_addr_props
>> 
>> v4:
>> a) do not use __ipv6_addr_needs_scope_id
>> 
>> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
>> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
...
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> 
> And I think this should go to -stable as well,.

Applied to 'net' and queued up for -stable, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-08 17:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-08 12:07 [PATCH net-next v4 3/4] ipv6: stop multicast forwarding to process interface scoped addresses Hannes Frederic Sowa
2013-03-08 16:30 ` YOSHIFUJI Hideaki
2013-03-08 17:28   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).