[PATCH net-next 0/5] Trivial patches

[PATCH net-next 0/5] Trivial patches

[Stephen Hemminger]

These are trivial patches to fix some sparse warnings.

[PATCH net-next 1/5] bna: fix declaration mismatch

[Stephen Hemminger]

[-- Attachment #1: bna-mismatch.patch --]
[-- Type: text/plain, Size: 815 bytes --]

The function is declared to take u32 but definition uses enum.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c	2013-03-08 10:33:19.142142147 -0800
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c	2013-03-08 10:33:21.534142211 -0800
@@ -76,7 +76,7 @@ static void bfa_ioc_pf_disabled(struct b
 static void bfa_ioc_pf_failed(struct bfa_ioc *ioc);
 static void bfa_ioc_pf_hwfailed(struct bfa_ioc *ioc);
 static void bfa_ioc_pf_fwmismatch(struct bfa_ioc *ioc);
-static void bfa_ioc_boot(struct bfa_ioc *ioc, u32 boot_type,
+static void bfa_ioc_boot(struct bfa_ioc *ioc, enum bfi_fwboot_type boot_type,
 			 u32 boot_param);
 static u32 bfa_ioc_smem_pgnum(struct bfa_ioc *ioc, u32 fmaddr);
 static void bfa_ioc_get_adapter_serial_num(struct bfa_ioc *ioc,

[PATCH net-next 2/5] Supject: phy: make local function static

[Stephen Hemminger]

[-- Attachment #1: phy-local.patch --]
[-- Type: text/plain, Size: 408 bytes --]

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/drivers/net/phy/lxt.c	2013-03-08 10:33:17.950142115 -0800
+++ b/drivers/net/phy/lxt.c	2013-03-08 10:33:22.210142229 -0800
@@ -159,7 +159,7 @@ static int lxt973a2_update_link(struct p
 	return 0;
 }
 
-int lxt973a2_read_status(struct phy_device *phydev)
+static int lxt973a2_read_status(struct phy_device *phydev)
 {
 	int adv;
 	int err;

[PATCH net-next 3/5] phy: vitesse make vsc824x_add_skew static

[Stephen Hemminger]

[-- Attachment #1: vitesse-local.patch --]
[-- Type: text/plain, Size: 710 bytes --]

Function is only used in this file, should be static and not
an exported symbol.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/drivers/net/phy/vitesse.c	2013-03-08 10:33:16.126142066 -0800
+++ b/drivers/net/phy/vitesse.c	2013-03-08 10:33:22.818142246 -0800
@@ -61,7 +61,7 @@ MODULE_DESCRIPTION("Vitesse PHY driver")
 MODULE_AUTHOR("Kriston Carson");
 MODULE_LICENSE("GPL");
 
-int vsc824x_add_skew(struct phy_device *phydev)
+static int vsc824x_add_skew(struct phy_device *phydev)
 {
 	int err;
 	int extcon;
@@ -81,7 +81,6 @@ int vsc824x_add_skew(struct phy_device *
 
 	return err;
 }
-EXPORT_SYMBOL(vsc824x_add_skew);
 
 static int vsc824x_config_init(struct phy_device *phydev)
 {

[PATCH net-next 4/5] team: make local function static

[Stephen Hemminger]

[-- Attachment #1: team-static.patch --]
[-- Type: text/plain, Size: 576 bytes --]

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/drivers/net/team/team.c	2013-03-06 15:30:50.195924953 -0800
+++ b/drivers/net/team/team.c	2013-03-08 10:34:45.446144458 -0800
@@ -503,9 +503,9 @@ static bool team_dummy_transmit(struct t
 	return false;
 }
 
-rx_handler_result_t team_dummy_receive(struct team *team,
-				       struct team_port *port,
-				       struct sk_buff *skb)
+static rx_handler_result_t team_dummy_receive(struct team *team,
+					      struct team_port *port,
+					      struct sk_buff *skb)
 {
 	return RX_HANDLER_ANOTHER;
 }

[PATCH net-next 5/5] dcb: fix sparse warnings

[Stephen Hemminger]

[-- Attachment #1: dcb-sparse.patch --]
[-- Type: text/plain, Size: 454 bytes --]

Add header with function definitions to quiet warnings and avoid future errors.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/net/dcb/dcbevent.c	2012-12-07 15:06:43.291665973 -0800
+++ b/net/dcb/dcbevent.c	2013-03-08 10:36:52.394147858 -0800
@@ -20,6 +20,7 @@
 #include <linux/rtnetlink.h>
 #include <linux/notifier.h>
 #include <linux/export.h>
+#include <net/dcbevent.h>
 
 static ATOMIC_NOTIFIER_HEAD(dcbevent_notif_chain);
 

RE: [PATCH net-next 1/5] bna: fix declaration mismatch

[Rasesh Mody]

>From: Stephen Hemminger [mailto:shemminger@vyatta.com]
>Sent: Friday, March 08, 2013 11:08 AM
>
>The function is declared to take u32 but definition uses enum.
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

You are right, thanks Stephen!

Acked-by: Rasesh Mody <rmody@brocade.com>

Re: [PATCH net-next 4/5] team: make local function static

[Jiri Pirko]

Fri, Mar 08, 2013 at 08:07:43PM CET, shemminger@vyatta.com wrote:
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
>
>--- a/drivers/net/team/team.c	2013-03-06 15:30:50.195924953 -0800
>+++ b/drivers/net/team/team.c	2013-03-08 10:34:45.446144458 -0800
>@@ -503,9 +503,9 @@ static bool team_dummy_transmit(struct t
> 	return false;
> }
> 
>-rx_handler_result_t team_dummy_receive(struct team *team,
>-				       struct team_port *port,
>-				       struct sk_buff *skb)
>+static rx_handler_result_t team_dummy_receive(struct team *team,
>+					      struct team_port *port,
>+					      struct sk_buff *skb)
> {
> 	return RX_HANDLER_ANOTHER;
> }
>
>

Acked-by: Jiri Pirko <jiri@resnulli.us>

Thanks Stephen.

Re: [PATCH net-next 0/5] Trivial patches

[David Miller]

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 08 Mar 2013 11:07:39 -0800

> These are trivial patches to fix some sparse warnings.

Series applied, thanks Stephen.