From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net-next] tunnel: use iptunnel_xmit() again Date: Sun, 10 Mar 2013 03:05:56 -0400 (EDT) Message-ID: <20130310.030556.572539791582239317.davem@davemloft.net> References: <1362883119-4099-1-git-send-email-xiyou.wangcong@gmail.com> <1362889787.4051.14.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org, pshelar@nicira.com, stephen@networkplumber.org To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:45963 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365Ab3CJHFw (ORCPT ); Sun, 10 Mar 2013 03:05:52 -0400 In-Reply-To: <1362889787.4051.14.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Sun, 10 Mar 2013 05:29:47 +0100 > On Sun, 2013-03-10 at 10:38 +0800, Cong Wang wrote: >> From: Cong Wang >> >> With recent patches from Pravin, most tunnels can't use iptunnel_xmit() >> any more, due to ip_select_ident() and skb->ip_summed. But we can just >> move these operations out of iptunnel_xmit(), so that tunnels can >> use it again. >> >> This by the way fixes a bug in vxlan (missing nf_reset()) for net-next. >> >> Cc: Pravin B Shelar >> Cc: Stephen Hemminger >> Cc: "David S. Miller" >> Signed-off-by: Cong Wang >> >> --- > > missing diffstat > > otherwise, patch looks good to me > > Acked-by: Eric Dumazet Applied, thanks.