From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: horms@verge.net.au, lvs-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCHv2 net-next 01/15] net: add skb_dst_set_unref
Date: Sun, 10 Mar 2013 17:00:04 -0400 (EDT) [thread overview]
Message-ID: <20130310.170004.2239870728229481365.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1303101527530.1608@ja.ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Sun, 10 Mar 2013 15:37:34 +0200 (EET)
> The idea looks good, here is the implementation.
> Can I use it in this form for next patchset versions?
Yes, but with one minor change:
> - if (unlikely(dst->flags & DST_NOCACHE)) {
> + if (unlikely(dst->flags & DST_NOCACHE && !force)) {
I keep forgetting the && vs. & operator precedence, and so
do many other people, so please put parenthesis around
the "dst->flags & DST_NOCACHE" expression, thanks.
next prev parent reply other threads:[~2013-03-10 20:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 21:16 [PATCHv2 net-next 00/15] IPVS optimizations Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 01/15] net: add skb_dst_set_unref Julian Anastasov
2013-03-10 9:17 ` David Miller
2013-03-10 13:37 ` Julian Anastasov
2013-03-10 21:00 ` David Miller [this message]
2013-03-10 22:05 ` Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 02/15] ipvs: avoid routing by TOS for real server Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 03/15] ipvs: prefer NETDEV_DOWN event to free cached dsts Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 04/15] ipvs: convert the IP_VS_XMIT macros to functions Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 05/15] ipvs: rename functions related to dst_cache reset Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 06/15] ipvs: no need to reroute anymore on DNAT over loopback Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 07/15] ipvs: do not use skb_share_check Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 08/15] ipvs: consolidate all dst checks on transmit in one place Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 09/15] ipvs: optimize dst usage for real server Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 10/15] ipvs: convert app locks Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 11/15] ipvs: remove rs_lock by using RCU Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 12/15] ipvs: convert locks used in persistence engines Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 13/15] ipvs: convert connection locking Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 14/15] ipvs: reorder keys in connection structure Julian Anastasov
2013-03-09 21:16 ` [PATCHv2 net-next 15/15] ipvs: avoid kmem_cache_zalloc in ip_vs_conn_new Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130310.170004.2239870728229481365.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).