From: David Miller <davem@davemloft.net>
To: andreea.cristina.hodea@gmail.com
Cc: mac@melware.de, isdn@linux-pingi.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hodea_andreea@yahoo.com
Subject: Re: [PATCH] eicon: Fixed checkpatch warning
Date: Sun, 10 Mar 2013 18:02:18 -0400 (EDT) [thread overview]
Message-ID: <20130310.180218.753487547136940085.davem@davemloft.net> (raw)
In-Reply-To: <20130310.165613.427736360718722534.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 10 Mar 2013 16:56:13 -0400 (EDT)
> From: Andreea Hodea <andreea.cristina.hodea@gmail.com>
> Date: Sun, 10 Mar 2013 14:34:36 +0200
>
>> drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
>> 'DRIVERRELEASE_DIDD' was not declared. Should it be static?
>>
>> Signed-off-by: Andreea Hodea <hodea_andreea@yahoo.com>
>
> Applied, thanks.
I had to revert, did you even try to compile the driver after
this change?
The symbol is refenced by DbgRegister() calls in diddfunc.c, and
a very simple grep would have shown that to you.
Please do not just blindly try to fix checkpatch warnings.
prev parent reply other threads:[~2013-03-10 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 12:34 [PATCH] eicon: Fixed checkpatch warning Andreea Hodea
2013-03-10 20:56 ` David Miller
2013-03-10 22:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130310.180218.753487547136940085.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreea.cristina.hodea@gmail.com \
--cc=hodea_andreea@yahoo.com \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).