* [PATCH] eicon: Fixed checkpatch warning
@ 2013-03-10 12:34 Andreea Hodea
2013-03-10 20:56 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andreea Hodea @ 2013-03-10 12:34 UTC (permalink / raw)
To: mac; +Cc: isdn, netdev, linux-kernel, Andreea Hodea
drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
'DRIVERRELEASE_DIDD' was not declared. Should it be static?
Signed-off-by: Andreea Hodea <hodea_andreea@yahoo.com>
---
drivers/isdn/hardware/eicon/diva_didd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/eicon/diva_didd.c b/drivers/isdn/hardware/eicon/diva_didd.c
index fab6ccf..21468be 100644
--- a/drivers/isdn/hardware/eicon/diva_didd.c
+++ b/drivers/isdn/hardware/eicon/diva_didd.c
@@ -29,7 +29,7 @@ static char *main_revision = "$Revision: 1.13.6.4 $";
static char *DRIVERNAME =
"Eicon DIVA - DIDD table (http://www.melware.net)";
static char *DRIVERLNAME = "divadidd";
-char *DRIVERRELEASE_DIDD = "2.0";
+static char *DRIVERRELEASE_DIDD = "2.0";
MODULE_DESCRIPTION("DIDD table driver for diva drivers");
MODULE_AUTHOR("Cytronics & Melware, Eicon Networks");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] eicon: Fixed checkpatch warning
2013-03-10 12:34 [PATCH] eicon: Fixed checkpatch warning Andreea Hodea
@ 2013-03-10 20:56 ` David Miller
2013-03-10 22:02 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-03-10 20:56 UTC (permalink / raw)
To: andreea.cristina.hodea; +Cc: mac, isdn, netdev, linux-kernel, hodea_andreea
From: Andreea Hodea <andreea.cristina.hodea@gmail.com>
Date: Sun, 10 Mar 2013 14:34:36 +0200
> drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
> 'DRIVERRELEASE_DIDD' was not declared. Should it be static?
>
> Signed-off-by: Andreea Hodea <hodea_andreea@yahoo.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] eicon: Fixed checkpatch warning
2013-03-10 20:56 ` David Miller
@ 2013-03-10 22:02 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-10 22:02 UTC (permalink / raw)
To: andreea.cristina.hodea; +Cc: mac, isdn, netdev, linux-kernel, hodea_andreea
From: David Miller <davem@davemloft.net>
Date: Sun, 10 Mar 2013 16:56:13 -0400 (EDT)
> From: Andreea Hodea <andreea.cristina.hodea@gmail.com>
> Date: Sun, 10 Mar 2013 14:34:36 +0200
>
>> drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
>> 'DRIVERRELEASE_DIDD' was not declared. Should it be static?
>>
>> Signed-off-by: Andreea Hodea <hodea_andreea@yahoo.com>
>
> Applied, thanks.
I had to revert, did you even try to compile the driver after
this change?
The symbol is refenced by DbgRegister() calls in diddfunc.c, and
a very simple grep would have shown that to you.
Please do not just blindly try to fix checkpatch warnings.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-10 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 12:34 [PATCH] eicon: Fixed checkpatch warning Andreea Hodea
2013-03-10 20:56 ` David Miller
2013-03-10 22:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).