From: Bill Fink <billfink@mindspring.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Vimal <j.vimal@gmail.com>,
netdev@vger.kernel.org, shemminger <shemminger@vyatta.com>
Subject: Re: [PATCH] Rate should be u64 to avoid integer overflow at high speeds (>= ~35Gbit)
Date: Sun, 10 Mar 2013 00:49:04 -0500 [thread overview]
Message-ID: <20130310004904.de508bfa.billfink@mindspring.com> (raw)
In-Reply-To: <1362891937.4051.25.camel@edumazet-glaptop>
On Sun, 10 Mar 2013, Eric Dumazet wrote:
> On Sat, 2013-03-09 at 20:53 -0800, Vimal wrote:
> > Ok, do you have suggestions on how to do this? Maybe a better way to
> > do this would be to introduce an additional "multipler" option for
> > rates, which is set to 1 as default, so actual rate can be computed as
> > multipler * rate supplied.
>
> How an old program, in binary form, will automatically knows it has to
> change its behavior to use an inexistent field ?
>
> I can use an old distro, and update kernel to upstream kernel, it must
> continue to work.
I don't see the problem. An old program would not know about
the new multiplier, would thus get the default multiplier of 1,
and get the same behavior as always, with the same limitation
of ~34 Gbps. But someone with a newer tc/kernel could for example
specify a multiplier of 10, which would then support rates up to
about 340 Gbps. It sounds like a reasonable approach to me.
-Bill
next prev parent reply other threads:[~2013-03-10 5:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 3:20 [PATCH] Rate should be u64 to avoid integer overflow at high speeds (>= ~35Gbit) Vimalkumar
2013-03-10 4:03 ` Eric Dumazet
2013-03-10 4:53 ` Vimal
2013-03-10 5:05 ` Eric Dumazet
2013-03-10 5:49 ` Bill Fink [this message]
2013-03-10 5:54 ` Eric Dumazet
2013-03-12 14:29 ` Chris Friesen
2013-03-12 15:42 ` Thomas Graf
2013-03-12 15:44 ` Eric Dumazet
2013-03-12 15:53 ` Chris Friesen
2013-03-12 15:56 ` Chris Friesen
2013-03-13 6:01 ` Bill Fink
2013-03-13 6:13 ` Eric Dumazet
2013-03-13 15:29 ` Bill Fink
2013-03-13 15:34 ` Stephen Hemminger
2013-03-13 16:57 ` Chris Friesen
2013-03-14 4:08 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130310004904.de508bfa.billfink@mindspring.com \
--to=billfink@mindspring.com \
--cc=eric.dumazet@gmail.com \
--cc=j.vimal@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).