* [PATCH net] bridge: reserve space for IFLA_BRPORT_FAST_LEAVE
@ 2013-03-11 23:52 Stephen Hemminger
2013-03-12 9:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2013-03-11 23:52 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The bridge multicast fast leave feature was added sufficient space
was not reserved in the netlink message. This means the flag may be
lost in netlink events and results of queries.
Found by observation while looking up some netlink stuff for discussion with Vlad.
Problem introduced by commit c2d3babfafbb9f6629cfb47139758e59a5eb0d80
Author: David S. Miller <davem@davemloft.net>
Date: Wed Dec 5 16:24:45 2012 -0500
bridge: implement multicast fast leave
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
Should go to net and stable for 3.8.X
--- a/net/bridge/br_netlink.c 2013-03-07 18:12:53.885287247 -0800
+++ b/net/bridge/br_netlink.c 2013-03-11 16:44:34.759166273 -0700
@@ -29,6 +29,7 @@ static inline size_t br_port_info_size(v
+ nla_total_size(1) /* IFLA_BRPORT_MODE */
+ nla_total_size(1) /* IFLA_BRPORT_GUARD */
+ nla_total_size(1) /* IFLA_BRPORT_PROTECT */
+ + nla_total_size(1) /* IFLA_BRPORT_FAST_LEAVE */
+ 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] bridge: reserve space for IFLA_BRPORT_FAST_LEAVE
2013-03-11 23:52 [PATCH net] bridge: reserve space for IFLA_BRPORT_FAST_LEAVE Stephen Hemminger
@ 2013-03-12 9:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-03-12 9:39 UTC (permalink / raw)
To: stephen; +Cc: netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 11 Mar 2013 16:52:17 -0700
> The bridge multicast fast leave feature was added sufficient space
> was not reserved in the netlink message. This means the flag may be
> lost in netlink events and results of queries.
>
> Found by observation while looking up some netlink stuff for discussion with Vlad.
> Problem introduced by commit c2d3babfafbb9f6629cfb47139758e59a5eb0d80
> Author: David S. Miller <davem@davemloft.net>
> Date: Wed Dec 5 16:24:45 2012 -0500
>
> bridge: implement multicast fast leave
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> ---
> Should go to net and stable for 3.8.X
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-12 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 23:52 [PATCH net] bridge: reserve space for IFLA_BRPORT_FAST_LEAVE Stephen Hemminger
2013-03-12 9:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).