From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: igb driver triggers BUILD_BUG_ON on s390
Date: Tue, 12 Mar 2013 07:59:00 +0100 [thread overview]
Message-ID: <20130312065900.GA4148@osiris> (raw)
In-Reply-To: <513DFC80.5000105@intel.com>
On Mon, Mar 11, 2013 at 08:47:12AM -0700, Alexander Duyck wrote:
> On 03/09/2013 02:00 AM, Heiko Carstens wrote:
> > git commit 74e238ead "igb: Support using build_skb in the case that
> > jumbo frames are disabled" added a BUILD_BUG_ON() to the igb drivers
> > which triggers on s390:
> >
> > drivers/net/ethernet/intel/igb/igb_main.c:6231:2:
> > error: call to ‘__compiletime_assert_6235’ declared with attribute error:
> > BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) <
> > (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH_FRAME_LEN + ETH_FCS_LEN)
> >
> > Any opinions?
> >
>
> A fix for this has already been submitted. As it turns out the
> BUILD_BUG_ON is mostly redundant anyway since we used a similar
> calculation to determine if we were going to enable the use of build_skb
> per ring.
Ok, thanks!
prev parent reply other threads:[~2013-03-12 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 10:00 igb driver triggers BUILD_BUG_ON on s390 Heiko Carstens
2013-03-11 15:47 ` Alexander Duyck
2013-03-12 6:59 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312065900.GA4148@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).