From: David Miller <davem@davemloft.net>
To: andreas.fenkart@streamunlimited.com
Cc: mugunthanvnm@ti.com, zonque@gmail.com, netdev@vger.kernel.org,
s.neumann@raumfeld.com, koen@dominion.thruhere.net
Subject: Re: [PATCH] net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc()
Date: Wed, 13 Mar 2013 04:51:50 -0400 (EDT) [thread overview]
Message-ID: <20130313.045150.2214781310963907722.davem@davemloft.net> (raw)
In-Reply-To: <20130312202027.GA935@blumentopf>
From: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Date: Tue, 12 Mar 2013 21:20:27 +0100
> On Wed, Mar 13, 2013 at 01:17:44AM +0530, Mugunthan V N wrote:
>> On 3/12/2013 10:01 PM, Daniel Mack wrote:
>> >Commit fae50823d0 ("net: ethernet: davinci_cpdma: Add boundary for rx
>> >and tx descriptors") introduced a function to check the current
>> >allocation state of tx packets. The return value is taken into account
>> >to stop the netqork queue on the adapter in case there are no free
>> >slots.
>> >
>> >However, cpdma_check_free_tx_desc() returns 'true' if there is room in
>> >the bitmap, not 'false', so the usage of the function is wrong.
>> >
>> >Signed-off-by: Daniel Mack <zonque@gmail.com>
>> >Cc: Mugunthan V N <mugunthanvnm@ti.com>
>> >Reported-by: Sven Neumann <s.neumann@raumfeld.com>
>> >Reported-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
...
>> Tested-by: Mugunthan V N <mugunthanvnm@ti.com>
>> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
...
> This restores throughput to the level of 3.7.0
>
> Tested-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Applied.
prev parent reply other threads:[~2013-03-13 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 16:31 [PATCH] net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc() Daniel Mack
2013-03-12 19:47 ` Mugunthan V N
2013-03-12 20:20 ` Andreas Fenkart
2013-03-13 8:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313.045150.2214781310963907722.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreas.fenkart@streamunlimited.com \
--cc=koen@dominion.thruhere.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=s.neumann@raumfeld.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).