From: David Miller <davem@davemloft.net>
To: vfalico@redhat.com
Cc: netdev@vger.kernel.org, lkml@tlinx.org, eric.dumazet@gmail.com,
fubar@us.ibm.com, jeffrey.t.kirsher@intel.com,
xiyou.wangcong@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH] bonding: don't call update_speed_duplex() under spinlocks
Date: Wed, 13 Mar 2013 04:53:36 -0400 (EDT) [thread overview]
Message-ID: <20130313.045336.984924610426807326.davem@davemloft.net> (raw)
In-Reply-To: <1363105892-3172-1-git-send-email-vfalico@redhat.com>
From: Veaceslav Falico <vfalico@redhat.com>
Date: Tue, 12 Mar 2013 17:31:32 +0100
> bond_update_speed_duplex() might sleep while calling underlying slave's
> routines. Move it out of atomic context in bond_enslave() and remove it
> from bond_miimon_commit() - it was introduced by commit 546add79, however
> when the slave interfaces go up/change state it's their responsibility to
> fire NETDEV_UP/NETDEV_CHANGE events so that bonding can properly update
> their speed.
>
> I've tested it on all combinations of ifup/ifdown, autoneg/speed/duplex
> changes, remote-controlled and local, on (not) MII-based cards. All changes
> are visible.
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2013-03-13 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 16:31 [PATCH] bonding: don't call update_speed_duplex() under spinlocks Veaceslav Falico
2013-03-13 8:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313.045336.984924610426807326.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=lkml@tlinx.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).