From: David Miller <davem@davemloft.net>
To: nsujir@broadcom.com
Cc: netdev@vger.kernel.org, marcinmiotk81@gmail.com, mchan@broadcom.com
Subject: Re: [PATCH net] tg3: 5715 does not link up when autoneg off
Date: Wed, 13 Mar 2013 10:00:11 -0400 (EDT) [thread overview]
Message-ID: <20130313.100011.730650469624132866.davem@davemloft.net> (raw)
In-Reply-To: <1363138368-10651-1-git-send-email-nsujir@broadcom.com>
From: "Nithin Nayak Sujir" <nsujir@broadcom.com>
Date: Tue, 12 Mar 2013 18:32:48 -0700
> From: Nithin Sujir <nsujir@broadcom.com>
>
> Commit d13ba512cbba7de5d55d7a3b2aae7d83c8921457 cleaned up the autoneg
> advertisement by removing some dead code. One effect of this change was that
> the advertisement register would not be updated if autoneg is turned off.
>
> This exposed a bug on the 5715 device w.r.t linking. The 5715 defaults
> to advertise only 10Mb Full duplex. But with autoneg disabled, it needs
> the configured speed enabled in the advertisement register to link up.
>
> This patch adds the work around to advertise all speeds on the 5715 when
> autoneg is disabled.
>
> Reported-by: Marcin Miotk <marcinmiotk81@gmail.com>
> Reviewed-by: Benjamin Li <benli@broadcom.com>
> Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
prev parent reply other threads:[~2013-03-13 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 1:32 [PATCH net] tg3: 5715 does not link up when autoneg off Nithin Nayak Sujir
2013-03-13 14:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313.100011.730650469624132866.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=marcinmiotk81@gmail.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).