From: David Miller <davem@davemloft.net>
To: poettner@ibr.cs.tu-bs.de
Cc: Linux-zigbee-devel@lists.sourceforge.net,
alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset
Date: Wed, 13 Mar 2013 10:38:30 -0400 (EDT) [thread overview]
Message-ID: <20130313.103830.247889330240632952.davem@davemloft.net> (raw)
In-Reply-To: <1363161054-13471-1-git-send-email-poettner@ibr.cs.tu-bs.de>
From: Wolf-Bastian Pöttner <poettner@ibr.cs.tu-bs.de>
Date: Wed, 13 Mar 2013 08:50:54 +0100
> offset has to be initialized, otherwise the *first* fragment will
> be discarded and reassembly cannot happen.
>
> Reviewed-by: Alan Ott <alan@signal11.us>
'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset)
succeeds, in which case it will be initialized properly. Otherwise we
unlock and drop the SKB and make no references whatsoever to 'offset'.
I suspect you saw some compiler warning about 'offset' being
uninitialized, and are just blindly trying to shut this warning up.
next prev parent reply other threads:[~2013-03-13 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 7:50 [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset Wolf-Bastian Pöttner
2013-03-13 14:38 ` David Miller [this message]
2013-03-13 14:40 ` Wolf-Bastian Pöttner
[not found] ` <D859EF9A-19A9-4F74-B59D-28FADBCE338A-G+tS6SCNB47quOJu9mQKZg@public.gmane.org>
2013-03-13 15:45 ` Alan Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313.103830.247889330240632952.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linux-zigbee-devel@lists.sourceforge.net \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=poettner@ibr.cs.tu-bs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).