From: Andreas Henriksson <andreas@fatal.se>
To: roopa@cumulusnetworks.com
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [iproute2] Fix -oneline output when alias present
Date: Wed, 13 Mar 2013 10:48:59 +0100 [thread overview]
Message-ID: <20130313094859.GA3097@amd64.fatal.se> (raw)
In-Reply-To: <1363125827-14129-1-git-send-email-roopa@cumulusnetworks.com>
Hi!
Just wanted to point out some minor style issues with your patch.
See below...
On Tue, Mar 12, 2013 at 12:03:47PM -0000, roopa@cumulusnetworks.com wrote:
[...]
> - if (do_link && tb[IFLA_IFALIAS])
> - fprintf(fp,"\n alias %s",
> + if (do_link && tb[IFLA_IFALIAS]) {
> + fprintf(fp, "%s", _SL_);
> + fprintf(fp," alias %s",
^^^ missing space here.
Also, why not use a single fprintf?
Like:
fprintf(fp, "%s alias %s",
_SL_,
> rta_getattr_str(tb[IFLA_IFALIAS]));
> + }
Then you wouldn't need these brackets either...
>
> if (do_link && show_stats) {
> if (tb[IFLA_STATS64])
--
Andreas Henriksson
next prev parent reply other threads:[~2013-03-13 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 22:03 [PATCH iproute2] Fix -oneline output when alias present roopa
2013-03-13 9:48 ` Andreas Henriksson [this message]
2013-03-13 12:20 ` [iproute2] " Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313094859.GA3097@amd64.fatal.se \
--to=andreas@fatal.se \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).