From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: kapranoff@inbox.ru, netdev@vger.kernel.org,
bhutchings@solarflare.com, peppe.cavallaro@st.com,
bruce.w.allan@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: Elimination the forced speed reduction algorithm.
Date: Fri, 15 Mar 2013 08:51:35 -0400 (EDT) [thread overview]
Message-ID: <20130315.085135.1979138622322564611.davem@davemloft.net> (raw)
In-Reply-To: <1363351729.2433.4.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Fri, 15 Mar 2013 05:48:49 -0700
> The phy code also uses non standard kernel style tests like
> if (CONSTANT == variable)
> instead of
> if (variable == CONSTANT)
Right, to trigger compile time errors when "=" is accidently used
instead of "==".
But the whole driver is like this already.
next prev parent reply other threads:[~2013-03-15 12:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 10:40 [PATCH] phy: Elimination the forced speed reduction algorithm Kirill Kapranov
2013-03-15 12:35 ` David Miller
2013-03-15 12:48 ` Joe Perches
2013-03-15 12:51 ` David Miller [this message]
2013-03-15 14:15 ` Kirill Kapranov
-- strict thread matches above, loose matches on Subject: below --
2013-03-26 13:34 Kirill Kapranov
2013-03-26 14:56 ` Kirill Kapranov
2013-03-26 16:11 ` David Miller
2013-03-26 16:59 ` David Miller
2013-03-29 18:38 ` David Miller
2013-04-01 13:51 ` Kirill Kapranov
2013-03-27 11:16 Kirill Kapranov
2013-03-27 17:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315.085135.1979138622322564611.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=joe@perches.com \
--cc=kapranoff@inbox.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).