From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver Date: Fri, 15 Mar 2013 12:42:10 +0100 Message-ID: <20130315124210.27d0794a@skate> References: <1359473048-26551-1-git-send-email-florian@openwrt.org> <1363284515-9865-1-git-send-email-florian@openwrt.org> <1363284515-9865-5-git-send-email-florian@openwrt.org> <514300E0.2030108@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, Grant Likely , Rob Herring , Rob Landley , Jason Cooper , Andrew Lunn , Russell King , Benjamin Herrenschmidt , Paul Mackerras , Lennert Buytenhek , Greg Kroah-Hartman , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org To: Florian Fainelli Return-path: In-Reply-To: <514300E0.2030108@openwrt.org> Sender: linux-doc-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Dear Florian Fainelli, On Fri, 15 Mar 2013 12:07:12 +0100, Florian Fainelli wrote: > Thanks to the help of Andrew Lunn, there is at least two known issues > with this patch version: > > - we need to move up the mvmdio line in > drivers/net/ethernet/marvell/Makefile to make sure that configs having > both mvmdio and mv643xx_eth built-in get the probing order right I don't think it's the right way of fixing the problem. If there is no dependency on the two devices through the device model (i.e they don't have a parent->child relationship), then the mv643xx_eth driver should probably return -EPROBE_DEFER when it can't find its PHY so that its ->probe() operation gets called once again by the kernel when other drivers (including mvmdio) have been probed. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com