Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pshelar@nicira.com
Cc: netdev@vger.kernel.org, jesse@nicira.com
Subject: Re: [PATCH v3 net-next 1/5] GRE: Refactor GRE tunneling code.
Date: Tue, 19 Mar 2013 10:19:27 -0400 (EDT)	[thread overview]
Message-ID: <20130319.101927.283956963598107880.davem@davemloft.net> (raw)
In-Reply-To: <1363680615-1751-1-git-send-email-pshelar@nicira.com>

From: Pravin B Shelar <pshelar@nicira.com>
Date: Tue, 19 Mar 2013 01:10:15 -0700

> @@ -0,0 +1,169 @@
> +#ifndef __NET_IP_TUNNELS_H
> +#define __NET_IP_TUNNELS_H 1
> +
> +#include <linux/if_tunnel.h>
> +#include <net/dsfield.h>
> +#include <net/gro_cells.h>
> +#include <net/inet_ecn.h>
> +#include <net/ip.h>
> +
> +/* Keep error state on tunnel for 30 sec */
> +#define IPTUNNEL_ERR_TIMEO	(30*HZ)
> +
> +/* 6rd prefix/relay information */
> +struct ip_tunnel_6rd_parm {
> +	struct in6_addr		prefix;

Please include <linux/in6.h> explicitly rather than getting the in6_addr
definition indirectly via linux/dsfield.h

Please audit the data types and interfaces used in the rest of this
header file and make sure all the proper includes are being explicitly
made.

Finally, if you haven't already, please do some sanity builds with
different combinations of IPV6 being on and off.

Thanks.

      reply	other threads:[~2013-03-19 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19  8:10 [PATCH v3 net-next 1/5] GRE: Refactor GRE tunneling code Pravin B Shelar
2013-03-19 14:19 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130319.101927.283956963598107880.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jesse@nicira.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox