Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dbaluta@ixiacom.com
Cc: willemb@google.com, edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] packet: Fix compile error
Date: Tue, 19 Mar 2013 18:07:22 -0400 (EDT)	[thread overview]
Message-ID: <20130319.180722.1735800542274116990.davem@davemloft.net> (raw)
In-Reply-To: <1363730481-7168-1-git-send-email-dbaluta@ixiacom.com>

From: Daniel Baluta <dbaluta@ixiacom.com>
Date: Wed, 20 Mar 2013 00:01:21 +0200

> PACKET_FANOUT_ROLLOVER and PACKET_FANOUT_FLAG_ROLLOVER are not declared in
> <tree>/usr/include/linux/if_packet.h together with the other PACKET_FANOUT_* macros
> as one would expect. This causes the following compilation error:
> <snip>
> psock_fanout.c: In function ‘test_control_single’:
> psock_fanout.c:230:23: error: ‘PACKET_FANOUT_ROLLOVER’ undeclared (first use in this function)
> </snip>
> 
> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>

No, in fact, all of these should be removed completely.

They are provided by the header files under linux/usr/include which
get created by the "make headers_install" rule.

So you either need to run the "make headers_install" rule before
building the tests, or install the updated headers under /usr/include
on your test machine.

I'll remove the defines from the test, thanks for pointing this
out.

  reply	other threads:[~2013-03-19 22:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 22:01 [PATCH net-next] packet: Fix compile error Daniel Baluta
2013-03-19 22:07 ` David Miller [this message]
2013-03-19 22:46   ` Daniel Baluta
2013-03-19 23:06     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130319.180722.1735800542274116990.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dbaluta@ixiacom.com \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox