* [PATCH] net: ethernet: davinci_emac: make local function emac_poll_controller() static
@ 2013-03-20 15:01 Wei Yongjun
[not found] ` <CAPgLHd8=u1jepO+Z0HExYyyybaYtVcdqk0yhtmnLUieUhEGLTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-20 17:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-03-20 15:01 UTC (permalink / raw)
To: grant.likely, rob.herring, davem, mugunthanvnm, jiri, agust,
bhutchings
Cc: yongjun_wei, netdev, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
emac_poll_controller() was not declared. It should be static.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/ti/davinci_emac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index ae1b77a..e38e3d8 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1438,7 +1438,7 @@ static int emac_poll(struct napi_struct *napi, int budget)
* Polled functionality used by netconsole and others in non interrupt mode
*
*/
-void emac_poll_controller(struct net_device *ndev)
+static void emac_poll_controller(struct net_device *ndev)
{
struct emac_priv *priv = netdev_priv(ndev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: davinci_emac: make local function emac_poll_controller() static
[not found] ` <CAPgLHd8=u1jepO+Z0HExYyyybaYtVcdqk0yhtmnLUieUhEGLTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-03-20 16:22 ` Mugunthan V N
0 siblings, 0 replies; 3+ messages in thread
From: Mugunthan V N @ 2013-03-20 16:22 UTC (permalink / raw)
To: Wei Yongjun
Cc: jiri-rHqAuBHg3fBzbRFIqnYvSA, netdev-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
bhutchings-s/n/eUQHGBpZroRs9YW3xA, davem-fT/PcQaiUtIeIZ0/mPfg9Q
On 3/20/2013 8:31 PM, Wei Yongjun wrote:
> From: Wei Yongjun<yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> emac_poll_controller() was not declared. It should be static.
>
> Signed-off-by: Wei Yongjun<yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
Acked-by: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: davinci_emac: make local function emac_poll_controller() static
2013-03-20 15:01 [PATCH] net: ethernet: davinci_emac: make local function emac_poll_controller() static Wei Yongjun
[not found] ` <CAPgLHd8=u1jepO+Z0HExYyyybaYtVcdqk0yhtmnLUieUhEGLTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-03-20 17:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-20 17:26 UTC (permalink / raw)
To: weiyj.lk
Cc: grant.likely, rob.herring, mugunthanvnm, jiri, agust, bhutchings,
yongjun_wei, netdev, devicetree-discuss
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Wed, 20 Mar 2013 23:01:45 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> emac_poll_controller() was not declared. It should be static.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-20 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-20 15:01 [PATCH] net: ethernet: davinci_emac: make local function emac_poll_controller() static Wei Yongjun
[not found] ` <CAPgLHd8=u1jepO+Z0HExYyyybaYtVcdqk0yhtmnLUieUhEGLTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-20 16:22 ` Mugunthan V N
2013-03-20 17:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).