From: David Miller <davem@davemloft.net>
To: willemb@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: fix psock_fanout selftest hash collision
Date: Wed, 20 Mar 2013 13:59:34 -0400 (EDT) [thread overview]
Message-ID: <20130320.135934.156565403641352244.davem@davemloft.net> (raw)
In-Reply-To: <20130320.123344.1566685302188091721.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 20 Mar 2013 12:33:44 -0400 (EDT)
> From: Willem de Bruijn <willemb@google.com>
> Date: Wed, 20 Mar 2013 02:42:44 -0400
>
>> Fix flaky results with PACKET_FANOUT_HASH depending on whether the
>> two flows hash into the same packet socket or not.
>>
>> Also adds tests for PACKET_FANOUT_LB and PACKET_FANOUT_CPU and
>> replaces the counting method with a packet ring.
>>
>> Signed-off-by: Willem de Bruijn <willemb@google.com>
>
> Applied, thanks. I'll retest on my sparc64 box later today.
Unfortunately, it's still broken there:
--------------------
running psock_fanout test
--------------------
test: control single socket
test: control multiple sockets
test: datapath 0x0
info: count=0,0, expect=0,0
info: count=0,0, expect=15,5
ERROR: incorrect queue lengths
info: count=0,0, expect=20,5
ERROR: incorrect queue lengths
info: trying alternate ports (4)
test: datapath 0x0
info: count=0,0, expect=0,0
info: count=0,0, expect=15,5
ERROR: incorrect queue lengths
info: count=0,0, expect=20,5
ERROR: incorrect queue lengths
info: trying alternate ports (3)
test: datapath 0x0
info: count=0,0, expect=0,0
info: count=0,0, expect=15,5
ERROR: incorrect queue lengths
info: count=0,0, expect=20,5
ERROR: incorrect queue lengths
info: trying alternate ports (2)
test: datapath 0x0
info: count=0,0, expect=0,0
info: count=0,0, expect=15,5
ERROR: incorrect queue lengths
info: count=0,0, expect=20,5
ERROR: incorrect queue lengths
info: trying alternate ports (1)
test: datapath 0x0
info: count=0,0, expect=0,0
info: count=0,0, expect=15,5
ERROR: incorrect queue lengths
info: count=0,0, expect=20,5
ERROR: incorrect queue lengths
info: trying alternate ports (0)
test: datapath 0x0
info: count=0,0, expect=0,0
info: count=0,0, expect=15,5
ERROR: incorrect queue lengths
info: count=0,0, expect=20,5
ERROR: incorrect queue lengths
test: datapath 0x1000
info: count=0,0, expect=0,0
info: count=0,0, expect=15,5
ERROR: incorrect queue lengths
info: count=0,0, expect=20,15
ERROR: incorrect queue lengths
test: datapath 0x1
info: count=0,0, expect=0,0
info: count=0,0, expect=10,10
ERROR: incorrect queue lengths
info: count=0,0, expect=18,17
ERROR: incorrect queue lengths
test: datapath 0x3
info: count=0,0, expect=0,0
info: count=0,0, expect=20,0
ERROR: incorrect queue lengths
info: count=0,0, expect=20,15
ERROR: incorrect queue lengths
test: datapath 0x2
info: count=0,0, expect=0,0
info: count=0,0, expect=20,0
ERROR: incorrect queue lengths
info: count=0,0, expect=20,0
ERROR: incorrect queue lengths
test: datapath 0x2
info: count=0,0, expect=0,0
info: count=0,0, expect=0,20
ERROR: incorrect queue lengths
info: count=0,0, expect=0,20
ERROR: incorrect queue lengths
[FAIL]
next prev parent reply other threads:[~2013-03-20 17:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 20:18 [PATCH net-next v3] packet: packet fanout rollover during socket overload Willem de Bruijn
2013-03-19 20:37 ` Eric Dumazet
2013-03-19 21:16 ` David Miller
2013-03-19 21:34 ` Willem de Bruijn
2013-03-20 6:37 ` Willem de Bruijn
2013-03-20 6:42 ` [PATCH net-next] net: fix psock_fanout selftest hash collision Willem de Bruijn
2013-03-20 16:33 ` David Miller
2013-03-20 17:59 ` David Miller [this message]
2013-03-21 0:07 ` Willem de Bruijn
2013-03-21 1:16 ` David Miller
2013-03-21 6:31 ` Daniel Borkmann
2013-03-21 17:27 ` Willem de Bruijn
2013-03-21 17:46 ` David Miller
2013-03-21 17:47 ` Daniel Borkmann
2013-03-21 18:00 ` Willem de Bruijn
2013-03-21 17:49 ` David Miller
2013-03-21 17:56 ` David Miller
2013-03-21 18:01 ` Willem de Bruijn
2013-03-21 18:10 ` [PATCH net-next] net: fix psock_fanout on sparc64 Willem de Bruijn
2013-03-21 18:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320.135934.156565403641352244.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).