netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] RxRPC: use copy_to_user() instead of memcpy()
@ 2013-03-18 10:55 Dan Carpenter
  2013-03-19 13:42 ` David Miller
  2013-03-19 13:59 ` David Howells
  0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2013-03-18 10:55 UTC (permalink / raw)
  To: David S. Miller, David Howells; +Cc: netdev, kernel-janitors

This is a user pointer.  Changing the memcpy() to copy_to_user()
fixes a hang on my system.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I'm not very familiar with this code, so please review this
carefully.

diff --git a/net/rxrpc/ar-recvmsg.c b/net/rxrpc/ar-recvmsg.c
index 4b48687..428501f 100644
--- a/net/rxrpc/ar-recvmsg.c
+++ b/net/rxrpc/ar-recvmsg.c
@@ -143,10 +143,15 @@ int rxrpc_recvmsg(struct kiocb *iocb, struct socket *sock,
 
 		/* copy the peer address and timestamp */
 		if (!continue_call) {
-			if (msg->msg_name && msg->msg_namelen > 0)
-				memcpy(msg->msg_name,
-				       &call->conn->trans->peer->srx,
-				       sizeof(call->conn->trans->peer->srx));
+			if (msg->msg_name && msg->msg_namelen > 0) {
+				ret = copy_to_user((void __user *)msg->msg_name,
+					&call->conn->trans->peer->srx,
+					sizeof(call->conn->trans->peer->srx));
+				if (ret) {
+					ret = -EFAULT;
+					goto copy_error;
+				}
+			}
 			sock_recv_ts_and_drops(msg, &rx->sk, skb);
 		}
 

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-03-20 15:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-18 10:55 [patch] RxRPC: use copy_to_user() instead of memcpy() Dan Carpenter
2013-03-19 13:42 ` David Miller
2013-03-19 13:59 ` David Howells
2013-03-19 22:51   ` Dan Carpenter
2013-03-20 10:23   ` David Howells
2013-03-20 15:52     ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).