From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Frank Li <Frank.Li@freescale.com>
Cc: lznuaa@gmail.com, davem@davemloft.net, s.hauer@pengutronix.de,
netdev@vger.kernel.org, shawn.guo@linaro.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 1/1 net-next] NET: FEC: dynamtic check DMA desc buff type
Date: Wed, 20 Mar 2013 17:04:18 +0100 [thread overview]
Message-ID: <20130320160418.GG20530@pengutronix.de> (raw)
In-Reply-To: <1357265063-30528-1-git-send-email-Frank.Li@freescale.com>
Hello,
On Fri, Jan 04, 2013 at 10:04:23AM +0800, Frank Li wrote:
> MX6 and mx28 support enhanced DMA descriptor buff to support 1588
> ptp. But MX25, MX3x, MX5x can't support enhanced DMA descriptor buff.
> Check fec type and choose correct DMA descriptor buff type.
>
> Remove static config CONFIG_FEC_PTP.
> ptp function will be auto detected.
Your patch (now as ff43da86c69d76a726ffe7d1666148960dc1d108 in v3.9-rc1)
breaks building with CONFIG_FEC=m:
ERROR: "fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined!
ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined!
IMHO you should build fec.o and fec_ptp.o into the same module as they
cannot live without each other anyhow.
Having said I wonder if it would be worthwile to support FEC without
PTP_1588_CLOCK. For example make the above three functions static
inlines if CONFIG_PTP_1588_CLOCK=n and drop the select on the latter.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-03-20 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 2:04 [PATCH v3 1/1 net-next] NET: FEC: dynamtic check DMA desc buff type Frank Li
2013-01-04 13:09 ` Sascha Hauer
2013-01-04 23:16 ` David Miller
2013-03-20 16:04 ` Uwe Kleine-König [this message]
2013-03-20 17:28 ` Ben Hutchings
2013-03-20 19:09 ` Ben Hutchings
2013-03-20 18:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320160418.GG20530@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).