From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: avagin@openvz.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, xemul@parallels.com, edumazet@google.com,
paulmck@linux.vnet.ibm.com, dhowells@redhat.com
Subject: Re: [PATCH] net: fix *_DIAG_MAX constants
Date: Thu, 21 Mar 2013 11:14:37 -0400 (EDT) [thread overview]
Message-ID: <20130321.111437.2012746070698745131.davem@davemloft.net> (raw)
In-Reply-To: <20130321144218.GF9046@casper.infradead.org>
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 21 Mar 2013 14:42:18 +0000
> On 03/21/13 at 06:18pm, Andrey Vagin wrote:
>> Follow the common pattern and define *_DIAG_MAX like:
>>
>> [...]
>> __XXX_DIAG_MAX,
>> };
>>
>> Because everyone is used to do:
>>
>> struct nlattr *attrs[XXX_DIAG_MAX+1];
>>
>> nla_parse([...], XXX_DIAG_MAX, [...]
>>
>> Reported-by: Thomas Graf <tgraf@suug.ch>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Pavel Emelyanov <xemul@parallels.com>
>> Cc: Eric Dumazet <edumazet@google.com>
>> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
>> Cc: David Howells <dhowells@redhat.com>
>> Signed-off-by: Andrey Vagin <avagin@openvz.org>
>
> Acked-by: Thomas Graf <tgraf@suug.ch>
So you're ACK'ing a patch that makes changes to files that don't even
exist in the repository?
Andrey, post a clean patch against 'net' that fixes these constants
for existing code, don't just assume that your original patch set is
applied and post changes relative to that. That's not how we work.
After the bug fix for the existing cases goes in, you have to repost
your original patch set on top of that.
next prev parent reply other threads:[~2013-03-21 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 14:18 [PATCH] net: fix *_DIAG_MAX constants Andrey Vagin
2013-03-21 14:42 ` Thomas Graf
2013-03-21 15:14 ` David Miller [this message]
2013-03-21 15:25 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321.111437.2012746070698745131.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avagin@openvz.org \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tgraf@suug.ch \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).