From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: davem@davemloft.net, Frank.Li@freescale.com,
netdev@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] fec: Unify fec_ptp.c and fec.c
Date: Thu, 21 Mar 2013 07:21:46 +0100 [thread overview]
Message-ID: <20130321062146.GL20530@pengutronix.de> (raw)
In-Reply-To: <1363810268-24398-1-git-send-email-festevam@gmail.com>
Hello Fabio,
On Wed, Mar 20, 2013 at 05:11:07PM -0300, Fabio Estevam wrote:
> Currently CONFIG_FEC=y generates two separate modules: fec_ptp.ko and fec.ko.
CONFIG_FEC=m
> These modules cannot be used independently, so it is better to unify them.
>
> Move fec_ptp.c code into fec.c and its definitions into fec.h.
>
> Suggested-by: Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
s/Koe/Kö/
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
You could note that you dropped the EXPORT_SYMBOLs. Other than that I
assume it's a 1:1 change?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-03-21 6:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 20:11 [PATCH] fec: Unify fec_ptp.c and fec.c Fabio Estevam
2013-03-21 6:21 ` Uwe Kleine-König [this message]
2013-03-21 10:02 ` Frank Li
2013-03-21 10:09 ` Uwe Kleine-König
2013-03-21 10:15 ` Frank Li
2013-03-21 10:31 ` Uwe Kleine-König
2013-03-21 9:46 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321062146.GL20530@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).