From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Frank Li <lznuaa@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>,
davem@davemloft.net, Frank.Li@freescale.com,
netdev@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] fec: Unify fec_ptp.c and fec.c
Date: Thu, 21 Mar 2013 11:09:49 +0100 [thread overview]
Message-ID: <20130321100949.GO20530@pengutronix.de> (raw)
In-Reply-To: <CAHrpEqTd2mVaTW6pwJaHqYreDo6rT_6s_o=Z=OtU71PZzZCSVg@mail.gmail.com>
Hello,
On Thu, Mar 21, 2013 at 06:02:02PM +0800, Frank Li wrote:
> I suggest use below patch to fix this problem
>
> --- a/drivers/net/ethernet/freescale/Makefile
> +++ b/drivers/net/ethernet/freescale/Makefile
> @@ -2,7 +2,8 @@
> # Makefile for the Freescale network device drivers.
> #
>
> -obj-$(CONFIG_FEC) += fec.o fec_ptp.o
> +obj-$(CONFIG_FEC) += fec_driver.o
> +fec_driver-objs := fec.o fec_ptp.o
> obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
> ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)
> obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o
I thought about suggesting something similar, too. I would have renamed
fec.c to (say) fec_base.c and then kept the module name fec.ko. Not sure
keeping the module name is critical.
What is missing from your patch is dropping the EXPORT_SYMBOLs. Other
than that I like it better than using a single .c file.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-03-21 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 20:11 [PATCH] fec: Unify fec_ptp.c and fec.c Fabio Estevam
2013-03-21 6:21 ` Uwe Kleine-König
2013-03-21 10:02 ` Frank Li
2013-03-21 10:09 ` Uwe Kleine-König [this message]
2013-03-21 10:15 ` Frank Li
2013-03-21 10:31 ` Uwe Kleine-König
2013-03-21 9:46 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321100949.GO20530@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).