From: Thomas Graf <tgraf@suug.ch>
To: Masatake YAMATO <yamato@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal: shorten too long mcast group name
Date: Thu, 21 Mar 2013 13:04:12 +0000 [thread overview]
Message-ID: <20130321130412.GC9046@casper.infradead.org> (raw)
In-Reply-To: <1363693648-10015-3-git-send-email-yamato@redhat.com>
On 03/19/13 at 08:47pm, Masatake YAMATO wrote:
> The original name is too long.
>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> ---
> include/linux/thermal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index f0bd7f9..e3c0ae9 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -44,7 +44,7 @@
> /* Adding event notification support elements */
> #define THERMAL_GENL_FAMILY_NAME "thermal_event"
> #define THERMAL_GENL_VERSION 0x01
> -#define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_group"
> +#define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_grp"
Just saying that this would not be OK in general as this would
break any application looking up the multicast group id by name
via genetlink but since it's broken anyway right now it's OK I guess.
prev parent reply other threads:[~2013-03-21 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 11:47 [PATCH 0/2] netlink: protection and workaround for too long mcast group name Masatake YAMATO
2013-03-19 11:47 ` [PATCH 1/2] genetlink: trigger BUG_ON if a group name is too long Masatake YAMATO
2013-03-20 16:07 ` David Miller
2013-03-20 17:32 ` Ben Hutchings
2013-03-21 7:49 ` Masatake YAMATO
2013-03-20 21:01 ` Yinghai Lu
2013-03-20 21:05 ` David Miller
2013-03-20 21:06 ` Yinghai Lu
2013-03-20 21:13 ` David Miller
2013-03-20 21:16 ` Yinghai Lu
2013-03-20 22:10 ` David Miller
2013-03-20 22:17 ` Yinghai Lu
2013-03-20 22:18 ` David Miller
2013-04-23 9:27 ` Masatake YAMATO
2013-03-19 11:47 ` [PATCH 2/2] thermal: shorten too long mcast group name Masatake YAMATO
2013-03-20 16:08 ` David Miller
2013-03-21 7:46 ` Masatake YAMATO
2013-03-21 14:53 ` David Miller
[not found] ` <20130321.190819.892238877314124764.yamato@redhat.com>
2013-03-22 3:43 ` Masatake YAMATO
2013-03-22 14:04 ` David Miller
2013-03-21 13:04 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321130412.GC9046@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=netdev@vger.kernel.org \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).