From: Thomas Graf <tgraf@suug.ch>
To: Andrew Vagin <avagin@parallels.com>
Cc: Andrey Vagin <avagin@openvz.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Pavel Emelyanov <xemul@parallels.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Gao feng <gaofeng@cn.fujitsu.com>
Subject: Re: [PATCH 2/2] netlink: Diag core and basic socket info dumping
Date: Thu, 21 Mar 2013 14:41:20 +0000 [thread overview]
Message-ID: <20130321144120.GE9046@casper.infradead.org> (raw)
In-Reply-To: <20130321143119.GA14763@paralelels.com>
On 03/21/13 at 06:31pm, Andrew Vagin wrote:
> The code in ss looks like you described:
> struct rtattr *tb[UNIX_DIAG_MAX+1];
> ...
> parse_rtattr(tb, UNIX_DIAG_MAX, (struct rtattr*)(r+1),
> nlh->nlmsg_len - NLMSG_LENGTH(sizeof(*r)));
>
>
> struct rtattr *tb[NETLINK_DIAG_MAX+1];
> ...
> parse_rtattr(tb, NETLINK_DIAG_MAX, (struct rtattr*)(r+1),
> nlh->nlmsg_len - NLMSG_LENGTH(sizeof(*r)))
>
> I think I should only update headers... Or I don't understand something.
Right, fixing the headers will resolve the issue.
next prev parent reply other threads:[~2013-03-21 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 9:21 [PATCH 0/2] netlink: implement socket diag for netlink sockets Andrey Vagin
2013-03-21 9:21 ` [PATCH 1/2] net: prepare netlink code for netlink diag Andrey Vagin
2013-03-21 9:21 ` [PATCH 2/2] netlink: Diag core and basic socket info dumping Andrey Vagin
2013-03-21 11:46 ` Pavel Emelyanov
2013-03-21 12:52 ` Thomas Graf
2013-03-21 14:31 ` Andrew Vagin
2013-03-21 14:41 ` Thomas Graf [this message]
2013-03-21 9:33 ` [PATCH 0/4] ss: Get netlink sockets info via sock-diag Andrey Vagin
2013-03-21 9:33 ` [PATCH 1/4] ss: handle socket diag request in a separate function Andrey Vagin
2013-03-21 9:33 ` [PATCH 2/4] ss: create a function to print info about netlink sockets Andrey Vagin
2013-03-21 9:33 ` [PATCH 3/4] ss: show destination address for " Andrey Vagin
2013-03-21 9:33 ` [PATCH 4/4] ss: Get netlink sockets info via sock-diag Andrey Vagin
2013-03-21 17:00 ` [PATCH 0/4] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321144120.GE9046@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=avagin@openvz.org \
--cc=avagin@parallels.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).