From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [PATCH] net: fix *_DIAG_MAX constants Date: Thu, 21 Mar 2013 14:42:18 +0000 Message-ID: <20130321144218.GF9046@casper.infradead.org> References: <1363875500-14574-1-git-send-email-avagin@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Pavel Emelyanov , Eric Dumazet , "Paul E. McKenney" , David Howells To: Andrey Vagin Return-path: Content-Disposition: inline In-Reply-To: <1363875500-14574-1-git-send-email-avagin@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 03/21/13 at 06:18pm, Andrey Vagin wrote: > Follow the common pattern and define *_DIAG_MAX like: > > [...] > __XXX_DIAG_MAX, > }; > > Because everyone is used to do: > > struct nlattr *attrs[XXX_DIAG_MAX+1]; > > nla_parse([...], XXX_DIAG_MAX, [...] > > Reported-by: Thomas Graf > Cc: "David S. Miller" > Cc: Pavel Emelyanov > Cc: Eric Dumazet > Cc: "Paul E. McKenney" > Cc: David Howells > Signed-off-by: Andrey Vagin Acked-by: Thomas Graf