From: Kumar amit mehta <gmate.amit@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: eilong@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bnx2x: fix assignment of signed expression to unsigned variable
Date: Sat, 23 Mar 2013 13:45:11 -0700 [thread overview]
Message-ID: <20130323204511.GA18813@gmail.com> (raw)
In-Reply-To: <20130323195454.GB9138@mwanda>
On Sat, Mar 23, 2013 at 10:56:47PM +0300, Dan Carpenter wrote:
> On Sat, Mar 23, 2013 at 11:52:55AM -0700, Kumar Amit Mehta wrote:
> > fix for incorrect assignment of signed expression to unsigned variable.
> >
>
> This fix isn't right.
>
> > Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
> > ---
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
> > index 5682054..b90533a 100644
> > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
> > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c
> > @@ -2139,12 +2139,12 @@ static u8 bnx2x_dcbnl_get_cap(struct net_device *netdev, int capid, u8 *cap)
> > break;
> > default:
> > BNX2X_ERR("Non valid capability ID\n");
> > - rval = -EINVAL;
> > + rval = EINVAL;
> > break;
> > }
> > } else {
> > DP(BNX2X_MSG_DCB, "DCB disabled\n");
> > - rval = -EINVAL;
> > + rval = EINVAL;
>
> This function is called from dcbnl_getcap(). It returns zero on
> success, but it's not clear what it should return on failure. But
> certainly it's not a positive EINVAL.
>
> > }
> >
> > DP(BNX2X_MSG_DCB, "capid %d:%x\n", capid, *cap);
> > @@ -2154,7 +2154,7 @@ static u8 bnx2x_dcbnl_get_cap(struct net_device *netdev, int capid, u8 *cap)
> > static int bnx2x_dcbnl_get_numtcs(struct net_device *netdev, int tcid, u8 *num)
> > {
> > struct bnx2x *bp = netdev_priv(netdev);
> > - u8 rval = 0;
> > + s8 rval = 0;
>
> Just use "int" here.
>
> >
> > DP(BNX2X_MSG_DCB, "tcid %d\n", tcid);
> >
> > @@ -2188,7 +2188,7 @@ static int bnx2x_dcbnl_set_numtcs(struct net_device *netdev, int tcid, u8 num)
> > return -EINVAL;
> > }
> >
> > -static u8 bnx2x_dcbnl_get_pfc_state(struct net_device *netdev)
> > +static u8 bnx2x_dcbnl_get_pfc_state(struct net_device *netdev)
> > {
> > struct bnx2x *bp = netdev_priv(netdev);
> > DP(BNX2X_MSG_DCB, "state = %d\n", bp->dcbx_local_feat.pfc.enabled);
> > @@ -2282,7 +2282,7 @@ static int bnx2x_set_admin_app_up(struct bnx2x *bp, u8 idtype, u16 idval, u8 up)
> > else {
> > /* app table is full */
> > BNX2X_ERR("Application table is too large\n");
> > - return -EBUSY;
> > + return EBUSY;
> > }
>
> The fix for this is more involved. The function prototype should
> be changed to return an int. The caller should be updated to check
> for errors.
>
I wonder, why these callbacks are restricting the lower layers to return
only unsigned values, However Updating the prototype doesn't seem a good idea as
then it would require changes in various existing drivers.
next prev parent reply other threads:[~2013-03-23 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 18:52 [PATCH] bnx2x: fix assignment of signed expression to unsigned variable Kumar Amit Mehta
2013-03-23 19:56 ` Dan Carpenter
2013-03-23 20:45 ` Kumar amit mehta [this message]
2013-03-23 21:19 ` Dan Carpenter
2013-03-23 23:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130323204511.GA18813@gmail.com \
--to=gmate.amit@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=eilong@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).