From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar amit mehta <gmate.amit@gmail.com>
Cc: eilong@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bnx2x: fix assignment of signed expression to unsigned variable
Date: Sun, 24 Mar 2013 00:19:57 +0300 [thread overview]
Message-ID: <20130323211957.GC9138@mwanda> (raw)
In-Reply-To: <20130323204511.GA18813@gmail.com>
On Sat, Mar 23, 2013 at 01:45:11PM -0700, Kumar amit mehta wrote:
> On Sat, Mar 23, 2013 at 10:56:47PM +0300, Dan Carpenter wrote:
> >
> > The fix for this is more involved. The function prototype should
> > be changed to return an int. The caller should be updated to check
> > for errors.
> >
> I wonder, why these callbacks are restricting the lower layers to return
> only unsigned values, However Updating the prototype doesn't seem a good idea as
> then it would require changes in various existing drivers.
Yes. Everything will need to be updated. I've known this code is
buggy for years but I've never tried patching it because I'm very
lazy. :)
But actually it's only three drivers I think: bnx2x, ixgbe, and
mlx4. I suspect that most of the functions always return zero and
won't need to be modified.
regards,
dan carpenter
next prev parent reply other threads:[~2013-03-23 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 18:52 [PATCH] bnx2x: fix assignment of signed expression to unsigned variable Kumar Amit Mehta
2013-03-23 19:56 ` Dan Carpenter
2013-03-23 20:45 ` Kumar amit mehta
2013-03-23 21:19 ` Dan Carpenter [this message]
2013-03-23 23:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130323211957.GC9138@mwanda \
--to=dan.carpenter@oracle.com \
--cc=eilong@broadcom.com \
--cc=gmate.amit@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).