From: David Miller <davem@davemloft.net>
To: honkiko@gmail.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, zhiguo.hong@emc.com,
herbert@gondor.hengli.com.au
Subject: Re: [PATCH] bridge: fix crash when set mac address of br interface
Date: Sun, 24 Mar 2013 17:28:04 -0400 (EDT) [thread overview]
Message-ID: <20130324.172804.152818486141712380.davem@davemloft.net> (raw)
In-Reply-To: <1364041670-3408-1-git-send-email-honkiko@gmail.com>
From: Hong Zhiguo <honkiko@gmail.com>
Date: Sat, 23 Mar 2013 20:27:50 +0800
> When I tried to set mac address of a bridge interface to a mac
> address which already learned on this bridge, I got system hang.
>
> The cause is straight forward: function br_fdb_change_mac_address
> calls fdb_insert with NULL source nbp. Then an fdb lookup is
> performed. If an fdb entry is found and it's local, it's OK. But
> if it's not local, source is dereferenced for printk without NULL
> check.
>
> Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
Applied.
prev parent reply other threads:[~2013-03-24 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 12:27 [PATCH] bridge: fix crash when set mac address of br interface Hong Zhiguo
2013-03-24 21:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130324.172804.152818486141712380.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=herbert@gondor.hengli.com.au \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=zhiguo.hong@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox