Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kpark3469@gmail.com
Cc: richardcochran@gmail.com, keun-o.park@windriver.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] ptp_pch: eliminate a number of sparse warnings
Date: Wed, 27 Mar 2013 00:51:38 -0400 (EDT)	[thread overview]
Message-ID: <20130327.005138.1102221495315013055.davem@davemloft.net> (raw)
In-Reply-To: <1364359512-29228-1-git-send-email-kpark3469@gmail.com>

From: kpark3469@gmail.com
Date: Wed, 27 Mar 2013 13:45:12 +0900

> -module_param_string(station, pch_param.station, sizeof pch_param.station, 0444);
> +module_param_string(station,
> +	 pch_param.station, sizeof(pch_param.station), 0444);

Function arguments on the second and subsequent line of a function
call should line up with the first column after the colum of the
openning parenthesis of the first line.

Don't just use TAB characters exclusively, the above looks
incredibly ugly.  Instead use the necessary combination of
TAB and space characters necessary to make the argument
line up at the correct column so it all lines up and looks
nice.

  reply	other threads:[~2013-03-27  4:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  4:45 [PATCH] ptp_pch: eliminate a number of sparse warnings kpark3469
2013-03-27  4:51 ` David Miller [this message]
2013-03-27  4:59   ` Keun-O Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130327.005138.1102221495315013055.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=keun-o.park@windriver.com \
    --cc=kpark3469@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox