From: David Miller <davem@davemloft.net>
To: keescook@chromium.org
Cc: linux-kernel@vger.kernel.org, mcarlson@broadcom.com,
mchan@broadcom.com, netdev@vger.kernel.org, oded@privatecore.com,
spender@grsecurity.net, benli@broadcom.com
Subject: Re: [PATCH] tg3: fix length overflow in VPD firmware parsing
Date: Wed, 27 Mar 2013 14:11:26 -0400 (EDT) [thread overview]
Message-ID: <20130327.141126.2163700256471831702.davem@davemloft.net> (raw)
In-Reply-To: <20130327164050.GA26838@www.outflux.net>
From: Kees Cook <keescook@chromium.org>
Date: Wed, 27 Mar 2013 09:40:50 -0700
> Commit 184b89044fb6e2a74611dafa69b1dce0d98612c6 ("tg3: Use VPD fw version
> when present") introduced VPD parsing that contained a potential length
> overflow.
>
> Limit the hardware's reported firmware string length (max 255 bytes) to
> stay inside the driver's firmware string length (32 bytes). On overflow,
> truncate the formatted firmware string instead of potentially overwriting
> portions of the tg3 struct.
>
> http://cansecwest.com/slides/2013/PrivateCore%20CSW%202013.pdf
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Reported-by: Oded Horovitz <oded@privatecore.com>
> Reported-by: Brad Spengler <spender@grsecurity.net>
Applied.
prev parent reply other threads:[~2013-03-27 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 16:40 [PATCH] tg3: fix length overflow in VPD firmware parsing Kees Cook
2013-03-27 18:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327.141126.2163700256471831702.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benli@broadcom.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=oded@privatecore.com \
--cc=spender@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).