From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: jpr@f6fbb.org, linux-hams@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] yam: remove redundant null check on dev
Date: Wed, 27 Mar 2013 14:31:09 -0400 (EDT) [thread overview]
Message-ID: <20130327.143109.1828472656521608702.davem@davemloft.net> (raw)
In-Reply-To: <1364408704-27359-1-git-send-email-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Wed, 27 Mar 2013 18:25:04 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> yam_open has a redundant null check on null, it will
> never be called with dev == NULL. Remove this redundant check.
> This also cleans up a smatch warning:
>
> drivers/net/hamradio/yam.c:869 yam_open() warn: variable
> dereferenced before check 'dev' (see line 867)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2013-03-27 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 18:25 [PATCH v2] yam: remove redundant null check on dev Colin King
2013-03-27 18:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327.143109.1828472656521608702.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=jpr@f6fbb.org \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox