From: David Miller <davem@davemloft.net>
To: yuvalmin@broadcom.com
Cc: netdev@vger.kernel.org, ariele@broadcom.com, eilong@broadcom.com
Subject: Re: [PATCH net-next] bnx2x: handle spurious interrupts
Date: Wed, 27 Mar 2013 15:27:16 -0400 (EDT) [thread overview]
Message-ID: <20130327.152716.1731476572805884795.davem@davemloft.net> (raw)
In-Reply-To: <1364408379-4353-1-git-send-email-yuvalmin@broadcom.com>
From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Wed, 27 Mar 2013 20:19:39 +0200
> Since the driver must request the IRQ prior to enabling HW generation of
> interrupts, it would still need to ignore every interrupt arriving during that
> interval.
This is the real issue.
request_irq() must not be invoked until you are ready to handle
interrupts, and this means initializing any and all software
datastructures that might be accessed in the interrupt handler.
If this requirement is met, seeing NULL pointers is not possible.
I still reject this patch, please fix the fundamental issue instead,
thanks.
next prev parent reply other threads:[~2013-03-27 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 18:19 [PATCH net-next] bnx2x: handle spurious interrupts Yuval Mintz
2013-03-27 19:27 ` David Miller [this message]
2013-03-27 21:08 ` Yuval Mintz
2013-03-27 21:34 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-03-31 11:35 Yuval Mintz
2013-03-31 16:31 ` Ben Hutchings
2013-04-02 5:03 ` Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327.152716.1731476572805884795.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).