From: David Miller <davem@davemloft.net>
To: lw@cn.fujitsu.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [Bug 55861] New: PMTU discovery no longer works in Linux 3.6+ with routers that do not send next hop MTU information
Date: Wed, 27 Mar 2013 22:24:15 -0400 (EDT) [thread overview]
Message-ID: <20130327.222415.476535684177218299.davem@davemloft.net> (raw)
In-Reply-To: <5153A3E8.9000004@cn.fujitsu.com>
From: Li Wei <lw@cn.fujitsu.com>
Date: Thu, 28 Mar 2013 09:59:04 +0800
> It seems to be in icmp_unreach():
>
> case ICMP_FRAG_NEEDED:
> if (ipv4_config.no_pmtu_disc) {
> LIMIT_NETDEBUG(KERN_INFO pr_fmt("%pI4: fragmentation needed and DF set\n"),
> &iph->daddr);
> } else {
> info = ntohs(icmph->un.frag.mtu);
> if (!info)
> goto out;
>
> When MTU is zero, we skip the process in icmp_socket_deliver() which propagate
> this error to transport protocols.
No, really, MTU field should not be set to zero. It should be set to
the actual MTU value we should use.
If you remove this check then we'll go down to the ipv4 routing code
and use the minimum ipv4 MTU, you absolutely do not want that.
The old code, that was removed, would try to guess in this case using
a table, the guard for this code path had comment:
/* BSD 4.2 derived systems incorrectly adjust
* tot_len by the IP header length, and report
* a zero MTU in the ICMP message.
*/
So the machines sending these zero MTUs are very broken.
I'm not accomodating such broken systems, sorry.
prev parent reply other threads:[~2013-03-28 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 15:31 Fw: [Bug 55861] New: PMTU discovery no longer works in Linux 3.6+ with routers that do not send next hop MTU information Stephen Hemminger
2013-03-28 1:59 ` Li Wei
2013-03-28 2:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327.222415.476535684177218299.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lw@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).