Re: [PATCH net-next] net: fix compile error of implicit declaration of skb_probe_transport_header

[David Miller <davem@davemloft.net>]

From: Jason Wang <jasowang@redhat.com>
Date: Thu, 28 Mar 2013 11:12:06 +0800

> On 03/28/2013 10:46 AM, Ying Xue wrote:
>> The commit 40893fd(net: switch to use skb_probe_transport_header())
>> involes a new error accidently. When NET_SKBUFF_DATA_USES_OFFSE is
>> not enabled, below compile error happens:
>>
>>   CC      net/packet/af_packet.o
>>   net/packet/af_packet.c: In function ‘packet_sendmsg_spkt’:
>>   net/packet/af_packet.c:1516:2: error: implicit declaration of function ‘skb_probe_transport_header’ [-Werror=implicit-function-declaration]
>>   cc1: some warnings being treated as errors
>>   make[2]: *** [net/packet/af_packet.o] Error 1
>>   make[1]: *** [net/packet] Error 2
>>   make: *** [net] Error 2
>>
>> As it seems skb_probe_transport_header() is not related to
>> NET_SKBUFF_DATA_USES_OFFSE, we should move the definition of
>> skb_probe_transport_header() out of scope of
>> NET_SKBUFF_DATA_USES_OFFSE macro.
>>
>> Cc: Jason Wang <jasowang@redhat.com>
>> Cc: Eric Dumazet <edumazet@google.com>
>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
>> ---
>>  include/linux/skbuff.h |   26 +++++++++++++-------------
>>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> Oops.
> 
> Acked-by: Jason Wang <jasowang@redhat.com>

Applied, thanks.