From: Stephen Hemminger <stephen@networkplumber.org>
To: Hong Zhiguo <honkiko@gmail.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net
Subject: Re: [PATCH net-next] bridge: remove unused variable ifm
Date: Thu, 28 Mar 2013 10:03:44 -0700 [thread overview]
Message-ID: <20130328100344.70c78134@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1364487682-5839-1-git-send-email-honkiko@gmail.com>
On Fri, 29 Mar 2013 00:21:22 +0800
Hong Zhiguo <honkiko@gmail.com> wrote:
> Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
> ---
> net/bridge/br_netlink.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index b96e02e..8e3abf5 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -352,17 +352,14 @@ static int br_setport(struct net_bridge_port *p, struct nlattr *tb[])
> /* Change state and parameters on port. */
> int br_setlink(struct net_device *dev, struct nlmsghdr *nlh)
> {
> - struct ifinfomsg *ifm;
> struct nlattr *protinfo;
> struct nlattr *afspec;
> struct net_bridge_port *p;
> struct nlattr *tb[IFLA_BRPORT_MAX + 1];
> int err = 0;
>
> - ifm = nlmsg_data(nlh);
> -
> - protinfo = nlmsg_find_attr(nlh, sizeof(*ifm), IFLA_PROTINFO);
> - afspec = nlmsg_find_attr(nlh, sizeof(*ifm), IFLA_AF_SPEC);
> + protinfo = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg), IFLA_PROTINFO);
> + afspec = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg), IFLA_AF_SPEC);
> if (!protinfo && !afspec)
> return 0;
>
> @@ -411,14 +408,11 @@ out:
> /* Delete port information */
> int br_dellink(struct net_device *dev, struct nlmsghdr *nlh)
> {
> - struct ifinfomsg *ifm;
> struct nlattr *afspec;
> struct net_bridge_port *p;
> int err;
>
> - ifm = nlmsg_data(nlh);
> -
> - afspec = nlmsg_find_attr(nlh, sizeof(*ifm), IFLA_AF_SPEC);
> + afspec = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg), IFLA_AF_SPEC);
> if (!afspec)
> return 0;
>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2013-03-28 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 16:21 [PATCH net-next] bridge: remove unused variable ifm Hong Zhiguo
2013-03-28 17:03 ` Stephen Hemminger [this message]
2013-03-28 18:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328100344.70c78134@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=honkiko@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox