From: Thomas Graf <tgraf@suug.ch>
To: Hong zhi guo <honkiko@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
stephen@networkplumber.org
Subject: Re: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg_*
Date: Thu, 28 Mar 2013 18:01:42 +0000 [thread overview]
Message-ID: <20130328180142.GJ23043@casper.infradead.org> (raw)
In-Reply-To: <CAA7+ByVp4K__=mESAu4jEy=t4TJD+rV0KOA2ZhHSinm1fvedzg@mail.gmail.com>
On 03/29/13 at 12:08am, Hong zhi guo wrote:
> Thanks, Thomas. But I didn't change any formatting. Just do the
> substitution in place.
Your change would require reformatting on the lines following
your change because the required level of indentation changed.
I don't want to cause you unneeded pain but it really helps
everyone used to the kernel coding style.
> >> - rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) +
> >> - sizeof(struct inet_diag_meminfo) +
> >> - 64)), GFP_KERNEL);
> >> + rep = nlmsg_new(sizeof(struct inet_diag_msg) +
> >> + sizeof(struct inet_diag_meminfo) + 64,
> >> + GFP_KERNEL);
^^^^^^^^^^^^^^
> Should I re-format and re-send the patch?
Yes please, just resubmit the patches that changed and include
a proper vN in the subject.
next prev parent reply other threads:[~2013-03-28 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 16:47 [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg_* Hong Zhiguo
2013-03-28 14:32 ` Thomas Graf
2013-03-28 16:08 ` Hong zhi guo
2013-03-28 18:01 ` Thomas Graf [this message]
2013-03-28 18:00 ` David Miller
2013-03-28 18:28 ` David Miller
2013-03-29 2:57 ` Brian Haley
2013-03-29 13:22 ` [PATCH] netlink: fix the warning introduced by netlink API replacement Hong Zhiguo
2013-03-29 13:58 ` Thomas Graf
2013-03-29 15:09 ` [PATCH v2 net-next] " Hong Zhiguo
2013-03-29 18:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328180142.GJ23043@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=honkiko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).