From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: shmulik.ladkani@gmail.com, greearb@candelatech.com,
netdev@vger.kernel.org, rgohita@gmail.com
Subject: Re: [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb'
Date: Fri, 29 Mar 2013 15:26:06 -0400 (EDT) [thread overview]
Message-ID: <20130329.152606.1390301950426444505.davem@davemloft.net> (raw)
In-Reply-To: <1364584656.5113.55.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 29 Mar 2013 12:17:36 -0700
> On Fri, 2013-03-29 at 15:11 -0400, David Miller wrote:
>> From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>> Date: Thu, 28 Mar 2013 11:13:26 +0200
>>
>> > 'nf_reset' is called just prior calling 'netif_rx'.
>> > No need to call it twice.
>> >
>> > Reported-by: Igor Michailov <rgohita@gmail.com>
>> > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>>
>> I do not see this happening in the:
>>
>> macvlan_start_xmit()
>>
>> --> macvlan_queue_xmit()
>>
>> code path.
>>
>> I'm not applying this patch. There seems to be no real agreement
>> that the caller of dev_forward_skb() takes care of the nf_reset().
>>
>> And wouldn't it be better to consolidate the nf_reset() calls
>> into one place instead of several, increasing the audit burdon.
>>
>
> Hmm, I believe you misread this patch :
>
> nf_reset() is called _twice_ in dev_forward_skb()
Aha, that makes more sense, applied.
prev parent reply other threads:[~2013-03-29 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:13 [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb' Shmulik Ladkani
2013-03-28 13:36 ` Eric Dumazet
2013-03-29 19:11 ` David Miller
2013-03-29 19:17 ` Eric Dumazet
2013-03-29 19:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329.152606.1390301950426444505.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=rgohita@gmail.com \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).