From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: netdev@vger.kernel.org, vyasevich@gmail.com
Subject: Re: [net-next PATCH] net: rtnetlink: fdb dflt dump must set idx used for cb->arg[0]
Date: Fri, 29 Mar 2013 15:27:04 -0400 (EDT) [thread overview]
Message-ID: <20130329.152704.895903622717759647.davem@davemloft.net> (raw)
In-Reply-To: <20130329181831.9902.70451.stgit@nitbit.x32>
From: John Fastabend <john.fastabend@gmail.com>
Date: Fri, 29 Mar 2013 11:18:37 -0700
> In rtnl_fdb_dump() when the fdb_dump ndo op is not populated
> we never set the idx value so that cb->arg[0] is always 0.
> Resulting in a endless loop of messages.
>
> Introduced with this commit,
>
> commit 090096bf3db1c281ddd034573260045888a68fea
> Author: Vlad Yasevich <vyasevic@redhat.com>
> Date: Wed Mar 6 15:39:42 2013 +0000
>
> net: generic fdb support for drivers without ndo_fdb_<op>
>
> CC: Vlad Yasevich <vyasevic@redhat.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied, thanks John.
prev parent reply other threads:[~2013-03-29 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 18:18 [net-next PATCH] net: rtnetlink: fdb dflt dump must set idx used for cb->arg[0] John Fastabend
2013-03-29 19:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329.152704.895903622717759647.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).