netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gang.chen@asianux.com
Cc: edumazet@google.com, dborkman@redhat.com, wad@chromium.org,
	eparis@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] include/linux: printk is needed in filter.h when CONFIG_BPF_JIT is defined
Date: Fri, 29 Mar 2013 15:34:47 -0400 (EDT)	[thread overview]
Message-ID: <20130329.153447.426374969178935845.davem@davemloft.net> (raw)
In-Reply-To: <5154ED65.5090607@asianux.com>

From: Chen Gang <gang.chen@asianux.com>
Date: Fri, 29 Mar 2013 09:24:53 +0800

> 
>   for make V=1 EXTRA_CFLAGS=-W ARCH=arm allmodconfig
>     printk is need when CONFIG_BPF_JIT is defined
>     or it will report pr_err and print_hex_dump are implicit declaration
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

There are no references to pr_err nor print_hex_dump in this
filter.h header file.

I think the issue is more like that the ARM bpf jit code uses
those routines, and therefore the ARM bpf jit code is what needs
to add these includes.

I'm not applying this patch, it isn't correct.

  reply	other threads:[~2013-03-29 19:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5153DC24.4010104@asianux.com>
2013-03-29  1:24 ` [PATCH v2] include/linux: printk is needed in filter.h when CONFIG_BPF_JIT is defined Chen Gang
2013-03-29 19:34   ` David Miller [this message]
2013-03-30  3:10     ` Chen Gang
2013-03-30  3:32       ` David Miller
2013-03-30  3:41         ` Chen Gang
2013-03-30  3:17     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130329.153447.426374969178935845.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=edumazet@google.com \
    --cc=eparis@redhat.com \
    --cc=gang.chen@asianux.com \
    --cc=netdev@vger.kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).