From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] include/linux: printk is needed in filter.h when CONFIG_BPF_JIT is defined Date: Fri, 29 Mar 2013 15:34:47 -0400 (EDT) Message-ID: <20130329.153447.426374969178935845.davem@davemloft.net> References: <5153DC24.4010104@asianux.com> <5154ED65.5090607@asianux.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: edumazet@google.com, dborkman@redhat.com, wad@chromium.org, eparis@redhat.com, netdev@vger.kernel.org To: gang.chen@asianux.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:56435 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756641Ab3C2Tet (ORCPT ); Fri, 29 Mar 2013 15:34:49 -0400 In-Reply-To: <5154ED65.5090607@asianux.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Chen Gang Date: Fri, 29 Mar 2013 09:24:53 +0800 > > for make V=1 EXTRA_CFLAGS=-W ARCH=arm allmodconfig > printk is need when CONFIG_BPF_JIT is defined > or it will report pr_err and print_hex_dump are implicit declaration > > Signed-off-by: Chen Gang There are no references to pr_err nor print_hex_dump in this filter.h header file. I think the issue is more like that the ARM bpf jit code uses those routines, and therefore the ARM bpf jit code is what needs to add these includes. I'm not applying this patch, it isn't correct.