* [PATCH V4 2/4] PHYLIB: queue work on unbound wq [not found] <cover.1364740180.git.viresh.kumar@linaro.org> @ 2013-03-31 14:31 ` Viresh Kumar 2013-03-31 16:45 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Viresh Kumar @ 2013-03-31 14:31 UTC (permalink / raw) To: tj Cc: linaro-kernel, patches, robin.randhawa, Steve.Bannister, Liviu.Dudau, charles.garcia-tobin, arvind.chauhan, davem, airlied, axboe, tglx, peterz, mingo, rostedt, linux-rt-users, linux-kernel, Viresh Kumar, netdev Phylib uses workqueues for multiple purposes. There is no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which the scheduler believes to be the most appropriate one. This patch replaces system_wq with system_unbound_wq for PHYLIB. Cc: David S. Miller <davem@davemloft.net> Cc: netdev@vger.kernel.org Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/net/phy/phy.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index c14f147..b2fe180 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -439,7 +439,7 @@ void phy_start_machine(struct phy_device *phydev, { phydev->adjust_state = handler; - schedule_delayed_work(&phydev->state_queue, HZ); + queue_delayed_work(system_unbound_wq, &phydev->state_queue, HZ); } /** @@ -500,7 +500,7 @@ static irqreturn_t phy_interrupt(int irq, void *phy_dat) disable_irq_nosync(irq); atomic_inc(&phydev->irq_disable); - schedule_work(&phydev->phy_queue); + queue_work(system_unbound_wq, &phydev->phy_queue); return IRQ_HANDLED; } @@ -655,7 +655,7 @@ static void phy_change(struct work_struct *work) /* reschedule state queue work to run as soon as possible */ cancel_delayed_work_sync(&phydev->state_queue); - schedule_delayed_work(&phydev->state_queue, 0); + queue_delayed_work(system_unbound_wq, &phydev->state_queue, 0); return; @@ -918,7 +918,8 @@ void phy_state_machine(struct work_struct *work) if (err < 0) phy_error(phydev); - schedule_delayed_work(&phydev->state_queue, PHY_STATE_TIME * HZ); + queue_delayed_work(system_unbound_wq, &phydev->state_queue, + PHY_STATE_TIME * HZ); } static inline void mmd_phy_indirect(struct mii_bus *bus, int prtad, int devad, -- 1.7.12.rc2.18.g61b472e ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V4 2/4] PHYLIB: queue work on unbound wq 2013-03-31 14:31 ` [PATCH V4 2/4] PHYLIB: queue work on unbound wq Viresh Kumar @ 2013-03-31 16:45 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2013-03-31 16:45 UTC (permalink / raw) To: viresh.kumar Cc: tj, linaro-kernel, patches, robin.randhawa, Steve.Bannister, Liviu.Dudau, charles.garcia-tobin, arvind.chauhan, airlied, axboe, tglx, peterz, mingo, rostedt, linux-rt-users, linux-kernel, netdev From: Viresh Kumar <viresh.kumar@linaro.org> Date: Sun, 31 Mar 2013 20:01:45 +0530 > Phylib uses workqueues for multiple purposes. There is no real dependency of > scheduling these on the cpu which scheduled them. > > On a idle system, it is observed that and idle cpu wakes up many times just to > service this work. It would be better if we can schedule it on a cpu which the > scheduler believes to be the most appropriate one. > > This patch replaces system_wq with system_unbound_wq for PHYLIB. > > Cc: David S. Miller <davem@davemloft.net> > Cc: netdev@vger.kernel.org > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: David S. Miller <davem@davemloft.net> ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <cover.1364739015.git.viresh.kumar@linaro.org>]
* [PATCH V4 2/4] PHYLIB: queue work on unbound wq [not found] <cover.1364739015.git.viresh.kumar@linaro.org> @ 2013-03-31 14:27 ` Viresh Kumar 0 siblings, 0 replies; 3+ messages in thread From: Viresh Kumar @ 2013-03-31 14:27 UTC (permalink / raw) To: tj Cc: linaro-kernel, patches, robin.randhawa, Steve.Bannister, Liviu.Dudau, charles.garcia-tobin, arvind.chauhan, davem, airlied, axboe, Viresh Kumar, netdev Phylib uses workqueues for multiple purposes. There is no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which the scheduler believes to be the most appropriate one. This patch replaces system_wq with system_unbound_wq for PHYLIB. Cc: David S. Miller <davem@davemloft.net> Cc: netdev@vger.kernel.org Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/net/phy/phy.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index c14f147..b2fe180 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -439,7 +439,7 @@ void phy_start_machine(struct phy_device *phydev, { phydev->adjust_state = handler; - schedule_delayed_work(&phydev->state_queue, HZ); + queue_delayed_work(system_unbound_wq, &phydev->state_queue, HZ); } /** @@ -500,7 +500,7 @@ static irqreturn_t phy_interrupt(int irq, void *phy_dat) disable_irq_nosync(irq); atomic_inc(&phydev->irq_disable); - schedule_work(&phydev->phy_queue); + queue_work(system_unbound_wq, &phydev->phy_queue); return IRQ_HANDLED; } @@ -655,7 +655,7 @@ static void phy_change(struct work_struct *work) /* reschedule state queue work to run as soon as possible */ cancel_delayed_work_sync(&phydev->state_queue); - schedule_delayed_work(&phydev->state_queue, 0); + queue_delayed_work(system_unbound_wq, &phydev->state_queue, 0); return; @@ -918,7 +918,8 @@ void phy_state_machine(struct work_struct *work) if (err < 0) phy_error(phydev); - schedule_delayed_work(&phydev->state_queue, PHY_STATE_TIME * HZ); + queue_delayed_work(system_unbound_wq, &phydev->state_queue, + PHY_STATE_TIME * HZ); } static inline void mmd_phy_indirect(struct mii_bus *bus, int prtad, int devad, -- 1.7.12.rc2.18.g61b472e ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-31 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1364740180.git.viresh.kumar@linaro.org>
2013-03-31 14:31 ` [PATCH V4 2/4] PHYLIB: queue work on unbound wq Viresh Kumar
2013-03-31 16:45 ` David Miller
[not found] <cover.1364739015.git.viresh.kumar@linaro.org>
2013-03-31 14:27 ` Viresh Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).