From: David Miller <davem@davemloft.net>
To: robherring2@gmail.com
Cc: linux@roeck-us.net, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, netdev@vger.kernel.org,
rob.herring@calxeda.com, david.daney@cavium.com
Subject: Re: [PATCH] of_net.h: Provide dummy functions if OF_NET is not configured
Date: Tue, 02 Apr 2013 14:33:19 -0400 (EDT) [thread overview]
Message-ID: <20130402.143319.1782388191427921383.davem@davemloft.net> (raw)
In-Reply-To: <5159DC82.3050804@gmail.com>
From: Rob Herring <robherring2@gmail.com>
Date: Mon, 01 Apr 2013 14:14:10 -0500
> On 04/01/2013 02:01 PM, Guenter Roeck wrote:
>> On Mon, Apr 01, 2013 at 01:44:24PM -0500, Rob Herring wrote:
>>> On 04/01/2013 01:19 PM, Guenter Roeck wrote:
>>>> of_get_mac_address() and of_get_phy_mode() are only provided if OF_NET
>>>> is configured. While most callers check for the define, not all do, and those
>>>> who do require #ifdef around the code. For those who don't, the missing check
>>>> can result in errors such as
>>>
>>> How about removing the ifdef from those callers?
>>>
>> That would be the next step, after/if this one is accepted.
>> If not, it doesn't make sense to waste my time.
>
> Assuming that is done:
>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
>
> Presumably with the follow-on patches, this can go in thru the net tree.
Indeed, please resubmit this with the follow-on cleanups.
Thanks.
prev parent reply other threads:[~2013-04-02 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 18:19 [PATCH] of_net.h: Provide dummy functions if OF_NET is not configured Guenter Roeck
2013-04-01 18:44 ` Rob Herring
2013-04-01 19:01 ` Guenter Roeck
[not found] ` <20130401190100.GA1042-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-04-01 19:14 ` Rob Herring
2013-04-02 18:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402.143319.1782388191427921383.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).