From: David Miller <davem@davemloft.net>
To: jacob.e.keller@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH v2] net: fix smatch warnings inside datagram_poll
Date: Tue, 02 Apr 2013 17:01:47 -0400 (EDT) [thread overview]
Message-ID: <20130402.170147.908732674571245473.davem@davemloft.net> (raw)
In-Reply-To: <20130402205539.26083.7462.stgit@jekeller-hub.jf.intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
Date: Tue, 2 Apr 2013 13:55:40 -0700
> Commit 7d4c04fc170087119727119074e72445f2bb192b ("net: add option to enable
> error queue packets waking select") has an issue due to operator precedence
> causing the bit-wise OR to bind to the sock_flags call instead of the result of
> the terniary conditional. This fixes the *_poll functions to work properly. The
> old code results in "mask |= POLLPRI" instead of what was intended, which is to
> only include POLLPRI when the socket option is enabled.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Much better, applied, thanks.
prev parent reply other threads:[~2013-04-02 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 20:55 [net-next PATCH v2] net: fix smatch warnings inside datagram_poll Jacob Keller
2013-04-02 21:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402.170147.908732674571245473.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).