From: Dan Carpenter <dan.carpenter@oracle.com>
To: pshelar@nicira.com
Cc: netdev@vger.kernel.org
Subject: re: GRE: Refactor GRE tunneling code.
Date: Tue, 2 Apr 2013 09:34:21 +0300 [thread overview]
Message-ID: <20130402063421.GA4826@longonot.mountain> (raw)
Hi Pravin,
I had a question about c54419321455: "GRE: Refactor GRE tunneling code."
from Mar 25, 2013:
net/ipv4/ip_gre.c
392 if (tpi->flags&TUNNEL_CSUM &&
393 !(skb_shinfo(skb)->gso_type & SKB_GSO_GRE)) {
394 *(__sum16 *)ptr = 0;
395 *(__sum16 *)ptr = csum_fold(skb_checksum(skb, 0,
396 skb->len, 0));
What are we doing here when we set *ptr = 0 and then reset it on the
next line? Is there a ptr++ or ptr-- missing?
397 }
regards,
dan carpenter
next reply other threads:[~2013-04-02 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 6:34 Dan Carpenter [this message]
2013-04-02 7:44 ` GRE: Refactor GRE tunneling code Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402063421.GA4826@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox